Add a method `toSavedStateHandle` to SafeArgs [193353880]

Fixed

Feature Request

Status Update

No update yet.

Description

hi...@a8c.com

created issue #1

Jul 12, 2021 12:22PM

Component used: Navigation Version used: 2.4.0-alpha02

With the addition of the function fromSavedStateHandle, it became easier to pass SafeArgs to the ViewModels using Hilt. But when trying to test those ViewModels, we still have to create the SavedStateHandle by hand, which is not optimal.

I would suggest generating a method tSavedStateHandle similar to the toBundle one, that creates a SavedStateHande object holding the arguments of the SafeArgs we need to test against, and that we can pass directly to the ViewModel's constructor.

Comments

br...@gmail.com <br...@gmail.com> #2Jul 12, 2021 12:40PM

This happens when fragments use animation whereby it doesn't wait for animations to complete and moves directly to RESUMED state.

The entry's listener to Fragment state does not get attached because it was attaching only if Fragment was in CREATED / STARTED state.

br...@gmail.com <br...@gmail.com> #3Jul 12, 2021 02:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit 16afaea63fc18ca7cc298e6650e0463083ba8ad7
Author: Clara Fok <clarafok@google.com>
Date: Mon Feb 27 17:27:15 2023

Fix FragmentNavigator resume states

Entries previously were not attaching fragment lifecycle observers because it would do so only if Fragment was STARTED or CREATED. But when using animations, Fragments would jump straight to RESUME and no observers would be attached.

Observers are now attached as long as Fragment is atleast STARTED. Since initial entry is not added to backStack, we store its entry to later attach an observer when its fragment is attached.

This CL also lays the foundation for attaching observers upon configuration changes / recreates.

Test: ./gradlew navigation:navigation-fragment:cC
Bug: 269646882
Relnote: "Fixes regression in navigation 2.6.0-alpha06 where NavBackStackEntry is not moved to RESUMED state"
Change-Id: Ib35896636c187da5bd11ea06234a3ea815fdeb68

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
A navigation/navigation-fragment/src/androidTest/res/anim/fade_enter.xml
A navigation/navigation-fragment/src/androidTest/res/anim/fade_exit.xml
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt

https://android-review.googlesource.com/2442040

il...@google.com <il...@google.com> Jul 19, 2021 11:21PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #4Jul 30, 2021 07:18PM

This has been fixed internally and will be available in navigation 2.6.0-alpha07

jb...@google.com <jb...@google.com> #5Aug 6, 2021 04:32PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit c73552953192ba60a879f5e51218f6e157a24beb
Author: Clara Fok <clarafok@google.com>
Date: Tue Feb 28 14:47:30 2023

Add FragmentNavigator test

Ensure initial fragments and their entries are correctly replaced and destroyed when navigate and popping consecutively

Test: ./gradlew navigation:navigation-fragment:cC
Bug: 269646882
Change-Id: I552ddd3d74f20612c4c91336eb4af9e6aa99c146

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/androidTest/res/navigation/nav_simple.xml

https://android-review.googlesource.com/2461555

hi...@a8c.com <hi...@a8c.com> #6Aug 9, 2021 11:10AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.6.0-alpha07

Issue 193353880