Fixed
Status Update
Comments
br...@gmail.com <br...@gmail.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
br...@gmail.com <br...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #4
deleted
jb...@google.com <jb...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
hi...@a8c.com <hi...@a8c.com> #6
Thanks so much for working on this.
Description
Component used: Navigation Version used: 2.4.0-alpha02
With the addition of the function
fromSavedStateHandle
, it became easier to pass SafeArgs to the ViewModels using Hilt. But when trying to test those ViewModels, we still have to create the SavedStateHandle by hand, which is not optimal.I would suggest generating a method
tSavedStateHandle
similar to thetoBundle
one, that creates aSavedStateHande
object holding the arguments of the SafeArgs we need to test against, and that we can pass directly to theViewModel
's constructor.