Add a method `toSavedStateHandle` to SafeArgs [193353880]

Fixed

Feature Request

Status Update

No update yet.

Description

hi...@a8c.com

created issue #1

Jul 12, 2021 12:22PM

Component used: Navigation Version used: 2.4.0-alpha02

With the addition of the function fromSavedStateHandle, it became easier to pass SafeArgs to the ViewModels using Hilt. But when trying to test those ViewModels, we still have to create the SavedStateHandle by hand, which is not optimal.

I would suggest generating a method tSavedStateHandle similar to the toBundle one, that creates a SavedStateHande object holding the arguments of the SafeArgs we need to test against, and that we can pass directly to the ViewModel's constructor.

Comments

br...@gmail.com <br...@gmail.com> #2Jul 12, 2021 12:40PM

since these are in public API (:/) we need to do this in 1.2

br...@gmail.com <br...@gmail.com> #3Jul 12, 2021 02:26PM

since it is already marked as deprecated, we can probably do it by now.

il...@google.com <il...@google.com> Jul 19, 2021 11:21PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #4Jul 30, 2021 07:18PM

Opening diff shortly

jb...@google.com <jb...@google.com> #5Aug 6, 2021 04:32PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

hi...@a8c.com <hi...@a8c.com> #6Aug 9, 2021 11:10AM

Thanks so much for working on this.

Issue 193353880