Fixed
Status Update
Comments
il...@google.com <il...@google.com>
[Deleted User] <[Deleted User]> #2
Forgot to mention, that crash occurs, when calling navController.navigate()
in "startDestination", when navigating to any other route. Example is probably not the best.
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 938a0cc7f71bf0c8c7556ef7fe2f772f9d0ec07c
Author: Ian Lake <ilake@google.com>
Date: Fri Jul 16 10:24:15 2021
Fix handling of deep links without URIs
When declaring a deep link without a URI, any
processing related to extracting arguments
from a URI should be disabled rather than
crashing.
Updated handleDeepLink() to ensure that
all Intents are considered as possible deep links
rather than only Intent that have a data URI.
Test: added tests pass
BUG: 193805425
Change-Id: I50da0def710703bff93080348fe9bcec0e8b9e3e
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
https://android-review.googlesource.com/1770006
Branch: androidx-main
commit 938a0cc7f71bf0c8c7556ef7fe2f772f9d0ec07c
Author: Ian Lake <ilake@google.com>
Date: Fri Jul 16 10:24:15 2021
Fix handling of deep links without URIs
When declaring a deep link without a URI, any
processing related to extracting arguments
from a URI should be disabled rather than
crashing.
Updated handleDeepLink() to ensure that
all Intents are considered as possible deep links
rather than only Intent that have a data URI.
Test: added tests pass
BUG: 193805425
Change-Id: I50da0def710703bff93080348fe9bcec0e8b9e3e
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
il...@google.com <il...@google.com> #4
This missed the cutoff for the 2.4.0-alpha05 release, so it'll be part of the alpha06 release. You can try out a snapshot by following the directions at
Description
Issue:
Creating a composable destination with deeplink, that does not have
uriPattern
set, crashes.Versions:
Component used: Navigation (Compose) Version used: androidx.navigation:navigation-compose:2.4.0-alpha04 Devices/Android versions reproduced on: Any
Stacktrace:
Example code: