Blurry image capture [193823892]

Fixed

Bug

Status Update

No update yet.

Description

er...@google.com

created issue on behalf of l....@gmail.com #1

Jul 15, 2021 09:37PM

Many users had reported that captured image is blur. Do we have any setting/workaround to avoid captured image being blurred? By the way, users also mentioned that using native camera image was NOT coming Blur.

Samsung Galaxy M21 (OS 10)
Samsung Galaxy J7 DUO (OS 9)
Xiaomi Mi 9T Pro
Samsung Galaxy S9+
Samsung Galaxy M20
Oppo realme C1
Sony Xperia L1, etc.

Comments

er...@google.com <er...@google.com> #2Jul 15, 2021 09:38PM

Reassigned to l....@gmail.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

l....@gmail.com <l....@gmail.com> #3Jul 19, 2021 05:49AM

CAMERAX VERSION (ex - 1.0.0-alpha07)
Users reported on 1.0.0-beta05, 1.0.0-rc02 & 1.0.0-rc04

CAMERA APPLICATION NAME AND VERSION: (Settings > Apps > (app name) > version)
Microsoft Lens

ANDROID OS BUILD NUMBER: (Settings > About > Build number)
Below are some devices fetched from playstore user comments.
a. Samsung Galaxy M21 (OS 10)
b. Samsung Galaxy J7 DUO (OS 9)
c. Xiaomi Mi 9T Pro
d. Samsung Galaxy S9+
e. Samsung Galaxy M20
f. Oppo realme C1
g. Sony Xperia L1, etc

DEVICE NAME: (Nexus 5X, Samsung S6, etc)
refer above

DESCRIPTION:
The captured image is blurred.

LIST ANY EXPERIMENTAL FEATURES: (As an example - @ExperimentalCamera2Interop)

STEPS TO REPRODUCE: 1. 2. 3.

OBSERVED RESULTS:

EXPECTED RESULTS:

REPRODUCIBILITY: (5 of 5, 1 of 100, etc)

ADDITIONAL INFORMATION:

CODE FRAGMENTS (this will help us troubleshoot your issues):
Image Capture usecase if configured as below:

imageCaptureUseCase = ImageCapture.Builder()
.setCaptureMode(ImageCapture.CAPTURE_MODE_MAXIMIZE_QUALITY)
.setTargetRotation(ROTATION_0)
.setTargetResolution(
Size(
currentCameraResolution.height,
currentCameraResolution.width
)
)
.build()

where "currentCameraResolution" is a resolution ~8MP

sc...@google.com <sc...@google.com> Aug 31, 2021 12:59AM

Accepted by sc...@google.com.

ap...@google.com <ap...@google.com> #4Sep 3, 2021 04:05AM

Project: platform/frameworks/support
Branch: androidx-main

commit edc83750c3c922f950f79d7f91b7a39f00518215
Author: repo sync -c -j8 <scottnien@google.com>
Date: Tue Aug 31 23:17:37 2021

Fixed the issue that captured photos are blurred in MAXIMIZE_QUALITY mode

Root cause: it is because we don't wait for AF focus lock before
issuing still capture rquest.

Solution:
When in CAPTURE_MODE_MAXIMIZE_QUALITY, imageCapture will now wait
for AF focus to lock or complete before issuing still capture
request.

Relnote: "Fix the issue where the captured photos are blurred
in MAXIMIZE_QUALITY mode."

Bug: 193823892
Test: Manual test
Change-Id: I173a99c55ee46bc78033ef0582b24acf4e432403

M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/adapter/CaptureResultAdapter.kt
M camera/camera-camera2/src/androidTest/java/androidx/camera/camera2/internal/Camera2CameraCaptureResultTest.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CameraCaptureResult.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/CameraCaptureMetaData.java

https://android-review.googlesource.com/1814876

sc...@google.com <sc...@google.com> #5Sep 3, 2021 04:18AM

Marked as fixed.

Hi Venkatech,

The blurry image issue is improved by this CL. It will be included in the upcoming release.

l....@gmail.com <l....@gmail.com> #6Sep 6, 2021 10:31AM

Thanks Scott.

Imagecapture will wait for AF merge only in "CAPTURE_MODE_MAXIMIZE_QUALITY" or for both "CAPTURE_MODE_MAXIMIZE_QUALITY" & "CAPTURE_MODE_MINIMIZE_LATENCY"?

Regards,
Venkatesh.

l....@gmail.com <l....@gmail.com> #7Sep 6, 2021 10:46AM

@Scott
"It will be included in the upcoming release."
Does this mean, fix will be available in "1.0.2" stable release?

sc...@google.com <sc...@google.com> #8Sep 7, 2021 02:18AM

It will wait for AF convergence only in CAPTURE_MODE_MAXIMIZE_QUALITY.

And we will schedule 1.0.2 stable release to include this fix.

l....@gmail.com <l....@gmail.com> #9Sep 7, 2021 08:02AM

Thanks Scott for update

ju...@google.com <ju...@google.com> #10Dec 7, 2022 06:35PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.camera:camera-core:1.2.0