Introduce DpSize [194219828]

Fixed

Bug

Status Update

No update yet.

Description

il...@jetbrains.com

created issue #1

Jul 20, 2021 08:48PM

There are Dp, DpOffset and even DpRect, but no DpSize … For some reason, I need DpSize much more often than offset or rect. Could you please add it for completeness?

Obviously, there should overloads for DpRect(DpOffset, DpSize), defaultMinSize modifier overload with DpSize and similar places.

Comments

ae...@google.com <ae...@google.com> Jul 20, 2021 10:32PM

Assigned to mo...@google.com.

mo...@google.com <mo...@google.com> #2Jul 20, 2021 11:47PM

Thanks for the feedback. We had it and removed it as we hadn't required it in the API.

This is a good idea for an update to 1.1

ap...@google.com <ap...@google.com> #3Jul 30, 2021 03:31PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit dae1d49459c9b0fc32ecde095b14aa3df61791b0
Author: George Mount <mount@google.com>
Date: Fri Jul 23 22:52:24 2021

Add DpSize

Fixes: 194219828

Customers need a DpSize structure.

RelNote: Added DpSize class

Test: new tests
Change-Id: I7abb129c8c18a3f77b68aec5c2060d2aad11a693

M compose/ui/ui-unit/api/current.txt
M compose/ui/ui-unit/api/public_plus_experimental_current.txt
M compose/ui/ui-unit/api/restricted_current.txt
M compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/Density.kt
M compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/Dp.kt
A compose/ui/ui-unit/src/test/kotlin/androidx/compose/ui/unit/DensityTest.kt
A compose/ui/ui-unit/src/test/kotlin/androidx/compose/ui/unit/DpSizeTest.kt

https://android-review.googlesource.com/1777126

ap...@google.com <ap...@google.com> #4Aug 3, 2021 11:07PM

Project: platform/frameworks/support
Branch: androidx-main

commit 24cdeaa19107b6815f7d26e225d089b2ae529c76
Author: George Mount <mount@google.com>
Date: Mon Aug 02 21:46:23 2021

Add constructor for DpRect(DpOffset, DpSize)

Bug: 194219828

Relnote: Added DpRect(DpOffset, DpSize) constructor

Test: new test
Change-Id: I2cf1636d05302a444587d6a6c43bd2e52c0a903f

M compose/ui/ui-unit/api/current.txt
M compose/ui/ui-unit/api/public_plus_experimental_current.txt
M compose/ui/ui-unit/api/restricted_current.txt
M compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/Dp.kt
M compose/ui/ui-unit/src/test/kotlin/androidx/compose/ui/unit/DpTest.kt

https://android-review.googlesource.com/1784199

ap...@google.com <ap...@google.com> #5Aug 5, 2021 09:57PM

Project: platform/frameworks/support
Branch: androidx-main

commit f4829e3a10aed3beffa283fdd0c8ce8f4afb3bfe
Author: George Mount <mount@google.com>
Date: Wed Aug 04 13:10:33 2021

Add DpSize versions of requiredSize and size modifiers

Bug: 194219828

As per the bug, Modifier.size() and Modifier.requiredSize()
would be useful with a DpSize argument.

Relnote: Added DpSize versions for Modifier.size and requiredSize

Test: new test
Change-Id: I3fc7e0a9bd9989a8217ccc2ecf9aaea047693e1d

M compose/foundation/foundation-layout/api/current.txt
M compose/foundation/foundation-layout/api/public_plus_experimental_current.txt
M compose/foundation/foundation-layout/api/restricted_current.txt
M compose/foundation/foundation-layout/build.gradle
M compose/foundation/foundation-layout/samples/src/main/java/androidx/compose/foundation/layout/samples/SizeModifierSample.kt
M compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/SizeTest.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Size.kt

https://android-review.googlesource.com/1786569

na...@gmail.com <na...@gmail.com> #6May 23, 2022 03:01PM

What about defaultMinSize?

mo...@google.com <mo...@google.com> #7May 24, 2022 03:25PM

You can file a feature request. We have a new member of the team who is ideal to implement it.