CameraX video recorder should support mirror or non-mirror output [194634656]

Fixed

Feature Request

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jul 26, 2021 11:40AM

A lot of social apps record video as mirrored when using front-camera to simplify users recording and position.

CameraX VideoCaptureConfig should provide some API to decide if the consumer wants the video to be registered as mirrored or reversed (current default).

Comments

[Deleted User] <[Deleted User]> #2Jul 26, 2021 12:25PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

er...@google.com <er...@google.com> #3Jul 26, 2021 04:53PM

Great! Thanks a lot, I'll look for the live updates soon!

an...@team.bumble.com <an...@team.bumble.com> #4Sep 10, 2021 09:01AM

Hi, we're heavily using CameraX API for recording video and this is much anticipated feature for us. Is there any timeframe for this issue? Thanks

wu...@google.com <wu...@google.com> #5Sep 10, 2021 09:25AM

Hi, it is expected to release the first alpha soon. This feature is in our current roadmap, but we are not able to provide an exact timeframe to support this feature. Please stay tuned. Thanks!

su...@gmail.com <su...@gmail.com> #6Oct 19, 2021 08:54AM

Hi, seems like the latest alpha doesn't have the changes, does it?

wu...@google.com <wu...@google.com> #7Oct 19, 2021 08:59AM

Yes, the first video capture library doesn't support mirror/non-mirror output, but it's in our pipeline. :)

an...@team.bumble.com <an...@team.bumble.com> #8Jan 21, 2022 05:03PM

Hi, are there any updates?

er...@google.com <er...@google.com> #9Jan 21, 2022 11:05PM

Hi there,

Thanks for the question - I've added this to our 1.2 candidate list so we'll be working on it. Note: We're going to be releasing 1.1 beta soon, then following the sem-versioning of 1.1 RC, 1.1 Stable, then proceeding to 1.2 branch. We hope the process with go more quickly this year. Thanks!

le...@google.com <le...@google.com> Jul 27, 2022 08:08AM

Status: Assigned (reopened)

kr...@gmail.com <kr...@gmail.com> #10Sep 8, 2022 03:20AM

+1 for this feature

wu...@google.com <wu...@google.com> Sep 21, 2022 08:42AM

Reassigned to le...@google.com.

le...@google.com <le...@google.com> Sep 28, 2022 07:51AM

Accepted by le...@google.com.

le...@google.com <le...@google.com> Sep 29, 2022 03:18AM

Assigned to le...@google.com.

le...@google.com <le...@google.com> Feb 17, 2023 03:44AM

Accepted by le...@google.com.

kh...@gmail.com <kh...@gmail.com> #11Mar 1, 2023 09:43AM

Hi there, any update on this?

le...@google.com <le...@google.com> #12Mar 1, 2023 09:48AM

Hi,

We are currently working on this feature and it is high priority. Stay tuned!

ap...@google.com <ap...@google.com> #13Mar 3, 2023 01:44AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4e979f702d053727557118464e0fb5ae4df9220f
Author: leo huang <leohuang@google.com>
Date: Tue Feb 14 18:04:22 2023

Apply mirror mode to VideoCapture, Preview and StreamSharing

- For Preview, MIRROR_MODE_FRONT_ON is the default value and can not be changed.
- For VideoCapture, add getMirrorMode()/Builder.setMirrorMode() which will be exposed later.
- For StreamSharing, VirtualCamera refers to UseCase mirror mode when generating child SurfaceProcessorNode.OutConfig.

Bug: 194634656
Test: ./gradlew camera:camera-core:testDebug; ./gradlew camera:camera-video:testDebug
Change-Id: I674c7bdf8b0516cefe298090549f5e22882cfddb

M camera/camera-core/src/main/java/androidx/camera/core/Preview.java
M camera/camera-core/src/main/java/androidx/camera/core/processing/SurfaceProcessorNode.java
M camera/camera-core/src/main/java/androidx/camera/core/streamsharing/VirtualCamera.java
M camera/camera-core/src/test/java/androidx/camera/core/PreviewTest.kt
M camera/camera-core/src/test/java/androidx/camera/core/streamsharing/VirtualCameraTest.kt
M camera/camera-video/src/main/java/androidx/camera/video/VideoCapture.java
M camera/camera-video/src/test/java/androidx/camera/video/VideoCaptureTest.kt

https://android-review.googlesource.com/2463056

ap...@google.com <ap...@google.com> #14Mar 3, 2023 01:44AM

Project: platform/frameworks/support
Branch: androidx-main

commit 0c78e313a38f1fee57742af743ad1fbb628255e9
Author: leo huang <leohuang@google.com>
Date: Tue Feb 14 16:01:29 2023

Add MirrorMode and apply to UseCases

- API design go/camerax-videocapture-mirroring
- The default mirror mode is MIRROR_MODE_OFF.
- Throw UnsupportedOperationException to Builder.setMirrorMode() by default.

Bug: 194634656
Test: ./gradlew camera:camera-core:testDebug; ./gradlew camera:camera-video:testDebug
Change-Id: If5128439c48b4b226c7fe6b8a6e6bcb516f16804

M camera/camera-core/src/androidTest/java/androidx/camera/core/UseCaseTest.kt
M camera/camera-core/src/main/java/androidx/camera/core/ImageAnalysis.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
A camera/camera-core/src/main/java/androidx/camera/core/MirrorMode.java
M camera/camera-core/src/main/java/androidx/camera/core/Preview.java
M camera/camera-core/src/main/java/androidx/camera/core/UseCase.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/ImageOutputConfig.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageAnalysisTest.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageCaptureTest.kt
M camera/camera-core/src/test/java/androidx/camera/core/PreviewTest.kt
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeCamera.java
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeUseCaseConfig.java
M camera/camera-video/src/main/java/androidx/camera/video/VideoCapture.java
M camera/camera-video/src/test/java/androidx/camera/video/VideoCaptureTest.kt

https://android-review.googlesource.com/2463055

vl...@team.bumble.com <vl...@team.bumble.com> #15Mar 13, 2023 03:34PM

Hello, are there any updates on when this is going live? Thank you

wu...@google.com <wu...@google.com> #16Mar 14, 2023 03:37AM

We are still working on this feature. Please stay tuned. Thanks!

ap...@google.com <ap...@google.com> #17Mar 21, 2023 03:29AM

Project: platform/frameworks/support
Branch: androidx-main

commit 3cf90a98c328801a87789aa49be70ecba685326b
Author: leo huang <leohuang@google.com>
Date: Fri Mar 03 10:07:51 2023

Expose VideoCapture mirroring API

Relnote: "Added VideoCapture mirroring APIs, including VideoCapture.Builder.setMirrorMode(int) and VideoCapture.getMirrorMode(). The APIs are useful for applications require the video recording to be consistent with common camera preview behavior, i.e. the rear camera preview is not mirrored but the front camera preview is mirrored."

Bug: 194634656
Test: ./gradlew camera:camera-video:testDebug
Change-Id: I713b6afc589947296d5f415694b7022c66ad0d66

M camera/camera-core/api/current.txt
M camera/camera-core/api/public_plus_experimental_current.txt
M camera/camera-core/api/restricted_current.txt
M camera/camera-core/src/androidTest/java/androidx/camera/core/UseCaseTest.kt
M camera/camera-core/src/main/java/androidx/camera/core/MirrorMode.java
M camera/camera-core/src/main/java/androidx/camera/core/Preview.java
M camera/camera-core/src/main/java/androidx/camera/core/UseCase.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/ImageOutputConfig.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageAnalysisTest.java
M camera/camera-core/src/test/java/androidx/camera/core/ImageCaptureTest.kt
M camera/camera-core/src/test/java/androidx/camera/core/PreviewTest.kt
M camera/camera-video/api/current.txt
M camera/camera-video/api/public_plus_experimental_current.txt
M camera/camera-video/api/restricted_current.txt
M camera/camera-video/src/main/java/androidx/camera/video/VideoCapture.java
M camera/camera-video/src/test/java/androidx/camera/video/VideoCaptureTest.kt
M camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/CameraXActivity.java

https://android-review.googlesource.com/2468860

an...@team.bumble.com <an...@team.bumble.com> #18Mar 21, 2023 09:32AM

Hi, thank you for your implementation, can we expect in in the 1.3.x release?

I can see that it's targeted to 1.3.0-alpha04 which has already happened

Message last modified on Mar 21, 2023 09:37AM

su...@gmail.com <su...@gmail.com> #19Mar 21, 2023 09:36AM

Comment has been deleted.

Message last modified on Mar 21, 2023 09:36AM

le...@google.com <le...@google.com> #20Mar 21, 2023 09:53AM

Oh, sorry, we didn't make it in time for 1.3.0-alpha04.

It will be the next release, i.e. 1.3.0-alpha06. (1.3.0-alpha05 is already on the release phase)

Update the "targeted to" as well.

an...@team.bumble.com <an...@team.bumble.com> #21Mar 21, 2023 09:58AM

Great news, thanks!

le...@google.com <le...@google.com> Mar 21, 2023 10:27AM

Marked as fixed.

pr...@google.com <pr...@google.com> #22Mar 22, 2023 08:23PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.camera:camera-core:1.3.0-alpha05
androidx.camera:camera-video:1.3.0-alpha05

kh...@gmail.com <kh...@gmail.com> #23Mar 23, 2023 03:42AM

Hope it will release soon. I am using ffmpeg and it increase apk size too much.

pr...@google.com <pr...@google.com> #24Apr 19, 2023 06:12PM