IssueTracker

Is there remaining work for this feature request. Support for predictive back in Dialogs would allow Material3 to remove some Dialog forks and would be very helpful!

Yeah, we probably want to investigate new API shapes here to take advantage of predictive back. No work ongoing yet though, needs prioritization

(recapping my chat with Ian)

The tricky part is that the onDismissRequest is really the final signal and a chance for the app to just say 'nope, I don't want the dialog to dismiss' (since they own the state of 'should the dialog be shown or not' simply by either adding the Dialog to composition or leaving out of composition) - that's the just-in-time problem that the comment talks about. It would be very odd to have any kind of progress animation that doesn't actually lead to the dialog being dismissed when it is committed"

so really it needs to be a more holistic look at how to do dialogs and swap from a binary state (shown/not shown) to something that actually has something in between for cases like predictive back

Navigation 2.4.0-alpha05 added crossfades between destinations, so those recompositions are indeed intentional. Glad you found the error though! Going to close this as working as intended.

Note that your BookViewModel can add a SavedStateHandle parameter which will automatically be filled with the arguments of your destination, allowing you to do one time initialization directly in the init block:

@HiltViewModel
class BookViewModel @Inject constructor(
  savedStateHandle: SavedStateHandle,
  // whatever other injected parameters you have
  private val repository: BookRepository
) : ViewModel() {

  init {
    val bookId = savedStateHandle.get<Long>("bookId")
    // Kick off your initialization here
  }
}