NPE in BridgeHoisting [195037294]

Verified

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jul 29, 2021 09:35PM

We are seeing a NPE in the BridgeHoisting that repros on 2.2.71, 2.2.75 and 2.2.80 versions of R8 but is not reproducible in 3.0.62

Stacktrace for R8 2.2.80:

Caused by: java.lang.NullPointerException
        at com.android.tools.r8.optimize.BridgeHoisting.createCodeForVirtualBridge(BridgeHoisting.java:297)
        at com.android.tools.r8.optimize.BridgeHoisting.hoistBridgeIfPossible(BridgeHoisting.java:242)
        at com.android.tools.r8.optimize.BridgeHoisting.processClass(BridgeHoisting.java:105)
        at com.android.tools.r8.optimize.BridgeHoisting.lambda$run$0(BridgeHoisting.java:87)
        at com.android.tools.r8.graph.ClassHierarchyTraversal.visit(ClassHierarchyTraversal.java:82)
        at com.android.tools.r8.graph.BottomUpClassHierarchyTraversal.visit(BottomUpClassHierarchyTraversal.java:7)
        at com.android.tools.r8.optimize.BridgeHoisting.run(BridgeHoisting.java:87)
        at com.android.tools.r8.R8.run(R8.java:735)
        at com.android.tools.r8.R8.run(R8.java:274)
        at com.android.tools.r8.R8.lambda$runForTesting$1(R8.java:265)
        at com.android.tools.r8.utils.ExceptionUtils.withCompilationHandler(ExceptionUtils.java:70)
        ... 134 more

Please let me know if additional details are required.

Comments

ch...@google.com <ch...@google.com> Aug 2, 2021 05:28AM

Reassigned to ch...@google.com.

ap...@google.com <ap...@google.com> #2Aug 2, 2021 08:29AM

So changing this section in my app/build.gradle file:

androidResources {
    noCompress 'tflite'
}

to this:

androidResources.noCompress = "tflite"

Solves my issue. I still consider this a bug though...

ap...@google.com <ap...@google.com> #3Aug 2, 2021 11:06AM

This will be fixed in AGP 7.1.0-alpha07 (before then it accidentally has an 'it' reciever)

androidResources {
    it.noCompress 'tflite'
}

It might be worth backporting the fix for a 7.0.1, or at least removing the deprecation of the aaptOptions block so others aren't lead to this broken path

ap...@google.com <ap...@google.com> #4Aug 2, 2021 02:55PM

redacted

ap...@google.com <ap...@google.com> #5Aug 2, 2021 02:55PM

Project: r8
Branch: 3.0

commit f11b84e86e9bc8138b7ba0760b41951c0f3e198b
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Aug 02 13:17:45 2021

Fix NPE from bridge hoisting of non-live bridges

Bug: 195037294
Change-Id: I4854ef3dd25f872563e650ea5636c38e06382c99

M src/main/java/com/android/tools/r8/graph/DexEncodedMethod.java
M src/main/java/com/android/tools/r8/ir/optimize/info/OptimizationFeedbackSimple.java
M src/main/java/com/android/tools/r8/ir/optimize/info/UpdatableMethodOptimizationInfo.java
M src/test/java/com/android/tools/r8/bridgeremoval/hoisting/AbstractAfterTreeShakingBridgeHoistingTest.java

https://r8-review.googlesource.com/61843

ap...@google.com <ap...@google.com> #6Aug 2, 2021 02:55PM

Project: r8
Branch: 3.0

commit 1e9c693b43b12e5a06bb6897304d73bed78ff0d9
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Aug 02 13:16:13 2021

Reproduce NPE from bridge hoisting of non-live bridges

Bug: 195037294
Change-Id: I92ab8cc255209179409b8c8af7b10106938deaf5

M src/main/java/com/android/tools/r8/optimize/bridgehoisting/BridgeHoisting.java
A src/test/java/com/android/tools/r8/bridgeremoval/hoisting/AbstractAfterTreeShakingBridgeHoistingTest.java

https://r8-review.googlesource.com/61842

ap...@google.com <ap...@google.com> #7Aug 2, 2021 02:55PM

Project: r8
Branch: 2.2

commit b5a69af3254459655a8c8d0f5cbf39746845d6a8
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Aug 02 14:13:56 2021

Version 2.2.81

Bug: 195037294
Change-Id: Iebe46051f19a7f17ebbc9c5daf4e64e4a5586de7

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/61850

ap...@google.com <ap...@google.com> #8Aug 2, 2021 02:55PM

Project: r8
Branch: 2.2

commit fbbd25ad819d62a4c72b26a24e8db0706cb50a1e
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Aug 02 14:09:05 2021

Fix NPE from bridge hoisting of non-live bridges

Bug: 195037294
Change-Id: I4854ef3dd25f872563e650ea5636c38e06382c99

M src/main/java/com/android/tools/r8/graph/DexEncodedMethod.java
M src/main/java/com/android/tools/r8/ir/optimize/info/OptimizationFeedbackSimple.java
M src/main/java/com/android/tools/r8/ir/optimize/info/UpdatableMethodOptimizationInfo.java
M src/test/java/com/android/tools/r8/bridgeremoval/hoisting/AbstractAfterTreeShakingBridgeHoistingTest.java

https://r8-review.googlesource.com/61848

ap...@google.com <ap...@google.com> #9Aug 2, 2021 02:55PM

Project: r8
Branch: 2.2

commit 61411ba98c78bbec784d105d3980b13eae9edbb7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Aug 02 14:01:50 2021

Reproduce NPE from bridge hoisting of non-live bridges

Bug: 195037294
Change-Id: I92ab8cc255209179409b8c8af7b10106938deaf5

A src/test/java/com/android/tools/r8/bridgeremoval/hoisting/AbstractAfterTreeShakingBridgeHoistingTest.java

https://r8-review.googlesource.com/61847

ap...@google.com <ap...@google.com> #10Aug 2, 2021 02:56PM

https://r8-review.googlesource.com/61843

ap...@google.com <ap...@google.com> #11Aug 2, 2021 02:56PM

https://r8-review.googlesource.com/61842

ap...@google.com <ap...@google.com> #12Aug 4, 2021 11:19AM

Project: r8
Branch: 3.0

commit 6fb5ed05b6b3ba790724a53a5abda5981fd20cf1
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 04 10:45:24 2021

Version 3.0.64

Bug: 195234829
Bug: 195037294
Change-Id: Icacacbec15e6bfc9a5c5663bca12b3b06f21cb05

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/61865

ap...@google.com <ap...@google.com> #13Aug 4, 2021 11:19AM

Project: r8
Branch: 2.2

commit 012bd3a37101c6bd659a094e68ccd77adb27c454
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Aug 04 10:36:21 2021

Version 2.2.82

Bug: 195234829
Bug: 195037294
Change-Id: I3d7b82263e06197f1c5b97531aa9e751d5037606

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/61862

ch...@google.com <ch...@google.com> #14Aug 5, 2021 06:46AM

Verified by ch...@google.com.

We managed to reproduce an NPE with the same stack trace in R8 2.2, 3.0, and 3.1. I expect the problematic code path was coincidentally not hit when you tried building with R8 3.0.62.

The fix is now available in R8 versions 2.2.82 and 3.0.64. Please confirm if this resolves the NPE you were seeing.

[Deleted User] <[Deleted User]> #15Aug 5, 2021 08:13AM

The fix has resolved the problem. Now build finishes successfully. Thank you!