HiltViewModel requires a viewModelStoreOwner that can only be a NavBackStackEntry, but does not work with arbitrary SavedStateRegistryOwner [195190169]

Fixed

Feature Request

Status Update

No update yet.

Description

zh...@gmail.com

created issue #1

Aug 1, 2021 01:19PM

Component used: Compose Version used: 2.38.1 Devices/Android versions reproduced on: Any

'androidx.hilt:hilt-navigation-compose:1.0.0-alpha03'

As per the code of

@Composable
@PublishedApi
internal fun createHiltViewModelFactory(
    viewModelStoreOwner: ViewModelStoreOwner
): ViewModelProvider.Factory? = if (viewModelStoreOwner is NavBackStackEntry) {
    HiltViewModelFactory(
        context = LocalContext.current,
        navBackStackEntry = viewModelStoreOwner
    )
} else {
    // Use the default factory provided by the ViewModelStoreOwner
    // and assume it is an @AndroidEntryPoint annotated fragment or activity
    null
}

The ViewModelStoreOwner only works if it is a NavBackStackEntry, but in reality, it should work with any arbitrary SavedStateRegistryOwner.

Comments

da...@google.com <da...@google.com> #2Aug 4, 2021 11:11PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

zh...@gmail.com <zh...@gmail.com> #3Aug 21, 2021 02:23PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

da...@google.com <da...@google.com> #4Sep 28, 2022 06:46PM

Reassigned to ku...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ku...@google.com <ku...@google.com> Oct 17, 2022 02:45PM

Accepted by ku...@google.com.

ap...@google.com <ap...@google.com> #5Feb 23, 2023 01:15PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0bd253de24bea5e6bc1a85405b7f9b9d365395ac
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Thu Nov 10 17:46:22 2022

Accept HasDefaultViewModelProviderFactory in hiltViewModel()

We excluded ViewModelStoreOwners that's not a NavBackStackEntry.
In this CL we accept it as long as it's a HasDefaultViewModelProviderFactory
as we can now get defaultArgs and savedStateRegistryOwner from
creationExtras.

Test: HiltViewModelComposeTest
Bug:

b/249548618

b/195190169

Relnote: Accept HasDefaultViewModelProviderFactory in hiltViewModel()

Change-Id: I10ab6e8b08e4eb2d27e0d7979e4a4f6663798245

M hilt/hilt-navigation-compose/src/androidTest/java/androidx/hilt/navigation/compose/HiltViewModelComposeTest.kt
M hilt/hilt-navigation-compose/src/main/java/androidx/hilt/navigation/compose/HiltViewModel.kt
M hilt/hilt-navigation-fragment/src/main/java/androidx/hilt/navigation/fragment/HiltNavGraphViewModelLazy.kt
M hilt/hilt-navigation/api/current.txt
M hilt/hilt-navigation/api/public_plus_experimental_current.txt
M hilt/hilt-navigation/api/restricted_current.txt
M hilt/hilt-navigation/src/main/java/androidx/hilt/navigation/HiltNavBackStackEntry.kt

https://android-review.googlesource.com/2297543

ku...@google.com <ku...@google.com> Apr 25, 2023 02:10PM

Marked as fixed.

Issue 195190169