Provide a built-in UUID type converter [195413406]

Fixed

Feature Request

Status Update

No update yet.

Description

da...@google.com

created issue #1

Aug 3, 2021 03:48PM

As @PrimaryKey users tend to use UUID but they have to build their own type converter for it. It would be nice if Room already had built-in support for UUID.

The typical UUID converter looks like this:

@TypeConverter
public UUID asUuid(byte[] bytes) {
    ByteBuffer bb = ByteBuffer.wrap(bytes);
    long firstLong = bb.getLong();
    long secondLong = bb.getLong();
    return new UUID(firstLong, secondLong);
}

@TypeConverter
public byte[] asBytes(UUID uuid) {
    ByteBuffer bb = ByteBuffer.wrap(new byte[16]);
    bb.putLong(uuid.getMostSignificantBits());
    bb.putLong(uuid.getLeastSignificantBits());
    return bb.array();
}

Comments

cl...@google.com <cl...@google.com> Aug 7, 2021 05:16AM

Accepted by cl...@google.com.

is...@google.com <is...@google.com> Aug 28, 2021 07:10AM

Status: New

da...@google.com <da...@google.com> Aug 30, 2021 03:06PM

Assigned to da...@google.com.

ap...@google.com <ap...@google.com> #2Sep 2, 2021 03:57PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 36ae9ec7a21c7a4fd43da5a250494c6196da1ca9
Author: Clara Fok <clarafok@google.com>
Date: Fri Aug 06 16:55:09 2021

Default converter for storing UUID

A default TypeAdapter for UUID that stores it as a byte array in the
database.

Used as a fallback default adapater if no custom TypeConverter for UUID is supplied.

If UUID field is annotated with TEXT TypeAffinity, it is still binded
and read as BLOB unless user provides two-way UUID/String converters.

Bug: 195413406
Fixes: 195413406
Test: ./gradlew :room:integration-tests:room-testapp-kotlin:cC
Test: ./gradlew :room:room-compiler:test
Change-Id: I40d526186711948521e534e0989319a628c8b82f

A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/UuidColumnTypeAdapterTest.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/xtype_ext.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/FieldProcessor.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
A room/room-compiler/src/main/kotlin/androidx/room/solver/types/UuidColumnTypeAdapter.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/BasicColumnTypeAdaptersTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
M room/room-runtime/api/restricted_current.txt
A room/room-runtime/src/main/java/androidx/room/util/UUIDUtil.java
A room/room-runtime/src/test/java/androidx/room/util/UUIDUtilTest.kt

https://android-review.googlesource.com/1812173

Issue 195413406

Description

Issue summary

Comments

cl...@google.com <cl...@google.com> Aug 7, 2021 05:16AM

is...@google.com <is...@google.com> Aug 28, 2021 07:10AM

da...@google.com <da...@google.com> Aug 30, 2021 03:06PM

ap...@google.com <ap...@google.com> #2Sep 2, 2021 03:57PM

Add comment

Issue metadata