painterResource() ignores ColorStateLists completely when inflating android:tint in VectorDrawables [195668138]

Fixed

Bug

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Aug 6, 2021 02:17AM

Current incorrect behavior

The painterResource() currently only supports inflating android:tint if it references a simple COLOR_INT resource type, meaning that ColorStateLists or theme attributes pointing to ColorStateLists are simply ignored (link to source code).

Desired correct behavior

android:tint should inflate the color state list using TypedArrayUtils#getNamedColor() instead, which would default to the ColorStateList's default value (since Compose does not have any understanding of drawable states used with Views).

This behavior would mirror the way that ColorStateLists are currently handled in a <path>'s android:fillColor and android:strokeColor, both of which fallback to the ColorStateList's default color (they inflate using TypedArrayUtils#getNamedComplexColor() here, which returns a ComplexColor wrapper around a ColorStateList. Then when the vector is rendered to the display, a simple SolidColor using the color state list's default color is returned here).

This would closely mirror the way that VectorDrawableCompat is inflated, which uses TypedArrayUtils#getNamedColorStateList() (source code here).

Reasons for fixing the bug

android:fillColor and android:strokeColor currently support color state lists but android:tint does not. Ideally they should both be supported if possible.
Many teams adopting Compose don't have an Icon solution as elegant as Material's (which generates ImageVectors as part of a separate artifact automatically). For example, our team, plans to continue inflating icons from our existing icon library defined in XML resources while adopting Compose, and all of these resources currently declare a default tint color using android:tint.

Version used: Compose v1.0.1

Comments

nj...@google.com <nj...@google.com> Aug 6, 2021 02:56AM

Assigned to nj...@google.com.

ap...@google.com <ap...@google.com> #2Aug 11, 2021 11:09PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit d0de70729f403e53893caf07bfc322ba7ffea655
Author: Nader Jawad <njawad@google.com>
Date: Mon Aug 09 13:29:05 2021

Add support for ColorStateList tint
properties

Relnote: "Updated Vector graphics xml
parsing to support ColorStateLists as
root color tint properties on VectorDrawables."

Fixes: 195668138
Test: Added tests to XmlVectorParserTest
Change-Id: I86915d08bdf50f729e91ec85c9f8595ad16f9562

M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/graphics/vector/compat/XmlVectorParserTest.kt
A compose/ui/ui/src/androidAndroidTest/res/drawable/ic_triangle_color_resource_tint.xml
A compose/ui/ui/src/androidAndroidTest/res/drawable/ic_triangle_color_theme_tint.xml
A compose/ui/ui/src/androidAndroidTest/res/drawable/ic_triangle_csl_tint.xml
A compose/ui/ui/src/androidAndroidTest/res/drawable/ic_triangle_csl_tint_theme.xml
M compose/ui/ui/src/androidAndroidTest/res/values/themes.xml
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/graphics/vector/compat/XmlVectorParser.android.kt
A compose/ui/ui/src/main/res/color/vector_tint_color.xml
A compose/ui/ui/src/main/res/color/vector_tint_theme_color.xml

https://android-review.googlesource.com/1790835

Issue 195668138