Fixed
Status Update
Comments
ry...@google.com <ry...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 9905c64f5b25d9c0872472e0345c2474ff579f93
Author: Chris Craik <ccraik@google.com>
Date: Tue Mar 05 15:58:05 2024
Add newline to IDE warnings so it's on a separate line from results
Fixes: 328308833
Test: InstrumentationResultsTest
Relnote: "Fixes method tracing warning to be on separate line from
microbench output"
Change-Id: I0455c4edcdc592c56e60dd19bd32d9bd33f6af6a
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/InstrumentationResultsTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/InstrumentationResults.kt
https://android-review.googlesource.com/2989187
Branch: androidx-main
commit 9905c64f5b25d9c0872472e0345c2474ff579f93
Author: Chris Craik <ccraik@google.com>
Date: Tue Mar 05 15:58:05 2024
Add newline to IDE warnings so it's on a separate line from results
Fixes: 328308833
Test: InstrumentationResultsTest
Relnote: "Fixes method tracing warning to be on separate line from
microbench output"
Change-Id: I0455c4edcdc592c56e60dd19bd32d9bd33f6af6a
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/InstrumentationResultsTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/InstrumentationResults.kt
Description
Currently, ComposeViews will dispose their compositions when detached from the window. In RecyclerView, this is slightly suboptimal, because ideally, we would only do so when the ViewHolder is being recycled, or when the RecyclerView is going away. See internal design doc for more information.
We should provide a simple solution (probably a recyclerview-compose artifact) that addresses this.