Fixed
Status Update
No update yet.
Comments
js...@google.com
lp...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
https://android-review.googlesource.com/1394868
Branch: androidx-master-dev
commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020
IconButton / IconToggleButton API scrub
Test: ./gradlew updateApi
Bug:
Bug:
Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
nj...@google.com
Divider seems like a good candidate to support Dp.Hairline, but I think it might need to be determined on a case by case basis. I could imagine it may not make sense to support Dp.Hairline for all composables/modifiers.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit efe6ccf3faccdd64c6d71b51cc35194d53e36d59
Author: Nader Jawad <njawad@google.com>
Date: Wed Aug 25 10:41:55 2021
Update Divider to respect Dp.Hairline
Relnote: "Updated Divider composable to
respect Dp.Hairline for the thickness parameter
to support drawing single pixel dividers
regardless of display density."
Fixes: 196840810
Test: Added test to DividerUiTest
Change-Id: I16ffb642eda86c17b65f56249686ffe67082ffe5
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/DividerUiTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Divider.kt
https://android-review.googlesource.com/1809156
Branch: androidx-main
commit efe6ccf3faccdd64c6d71b51cc35194d53e36d59
Author: Nader Jawad <njawad@google.com>
Date: Wed Aug 25 10:41:55 2021
Update Divider to respect Dp.Hairline
Relnote: "Updated Divider composable to
respect Dp.Hairline for the thickness parameter
to support drawing single pixel dividers
regardless of display density."
Fixes: 196840810
Test: Added test to DividerUiTest
Change-Id: I16ffb642eda86c17b65f56249686ffe67082ffe5
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/DividerUiTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Divider.kt
Description
It'd be nice if
DividersupportedDp.Hairline. In its current implementation, the divider becomes invisible ifDp.Hairlineis used.I'm currently working this around by manually calculating
1pxindp:I'd also like to call it out that it feels weird to have
Dp.Hairlineglobally available, only to realize that it's up to Composables to manually support it(?). From what I understand, onlyBorderStrokeandModifier.borderaccount for hairlines inv1.0.1.