Add support for Dp.Hairline to Divider [196840810]

Fixed

Bug

Status Update

No update yet.

Description

sa...@squareup.com

created issue #1

Aug 17, 2021 03:29PM

It'd be nice if Divider supported Dp.Hairline. In its current implementation, the divider becomes invisible if Dp.Hairline is used.

Divider(color = Color.LightGray, thickness = Dp.Hairline)

I'm currently working this around by manually calculating 1px in dp:

val density = LocalContext.current.resources.displayMetrics.density
val onePxInDp = (1f / density).dp

I'd also like to call it out that it feels weird to have Dp.Hairline globally available, only to realize that it's up to Composables to manually support it(?). From what I understand, only BorderStroke and Modifier.border account for hairlines in v1.0.1.

Comments

js...@google.com <js...@google.com> Aug 19, 2021 11:47PM

Assigned to lp...@google.com.

lp...@google.com <lp...@google.com> #2Aug 24, 2021 11:37PM

Reassigned to nj...@google.com.

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

nj...@google.com <nj...@google.com> #3Aug 25, 2021 12:07AM

Thanks for the report!

ap...@google.com <ap...@google.com> #4Aug 26, 2021 02:14PM

Marked as fixed.

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

Issue 196840810

Description

Issue summary

Comments

js...@google.com <js...@google.com> Aug 19, 2021 11:47PM

lp...@google.com <lp...@google.com> #2Aug 24, 2021 11:37PM

nj...@google.com <nj...@google.com> #3Aug 25, 2021 12:07AM

ap...@google.com <ap...@google.com> #4Aug 26, 2021 02:14PM

Add comment

Issue metadata