Make NavType name no longer abstract [196871885]

Fixed

Feature Request

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Aug 16, 2021 09:42PM

NavType should not require extended classes to override the name property. Name is used exclusively internal for NavInflater for classes that are inflated from XML. All the types that need to implement name already do, and custom NavTypes should not have this requirement.

Instead of being abstract, the name property should default to another string (i.e. "nav_type").

Comments

je...@gmail.com <je...@gmail.com> #2Aug 17, 2021 12:41AM

The only currently supported strategy for adding Fragments to compose is via AndroidViewBinding. Are you familiar with this approach?

ap...@google.com <ap...@google.com> #3Aug 18, 2021 08:02PM

Yes, I am familiar with AndroidViewBinding, however, as far as I know it has some limitations, like, I can't decide at runtime what fragment to commit.

ap...@google.com <ap...@google.com> #4Aug 19, 2021 10:25PM

I also can't give parameters to the fragment being inflated.

ap...@google.com <ap...@google.com> #5Aug 19, 2021 10:38PM

Project: platform/frameworks/support
Branch: androidx-main

commit ffe9335a155bf0dea9c3558e50da01d526579040
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Mar 26 20:24:54 2024

Create AndroidFragment to allow adding fragments in Compose

Adding new AndroidFragment API that creates the given Fragment class and
adds it to the enclosing FragmentManager, within Compose.

It handles setting the ViewCompositionStrategy and saving the state of
the fragment across recompositions.

RelNote: "The new AndroidFragment Composable allows adding fragments
into the Compose hierarchy via the fragment class name."
Test: added AndroidFragmentTest
Bug: 230126482
Bug: 312895363

Change-Id: Icf84199bbe487b2a2b6a95d2b6e09415f810e77a

M docs-tip-of-tree/build.gradle
M fragment/fragment-compose/api/current.txt
M fragment/fragment-compose/api/restricted_current.txt
M fragment/fragment-compose/build.gradle
A fragment/fragment-compose/samples/build.gradle
A fragment/fragment-compose/samples/src/main/java/androidx/fragment/compose/samples/FragmentComposeSamples.kt
M fragment/fragment-compose/src/androidTest/AndroidManifest.xml
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/AndroidFragmentTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/FragmentRecreateTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/FragmentRemoveTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/SimpleEditTextFragment.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/test/EmptyTestActivity.kt
A fragment/fragment-compose/src/androidTest/res/layout/content.xml
A fragment/fragment-compose/src/androidTest/res/layout/sample_edit_test_layout.xml
A fragment/fragment-compose/src/main/java/androidx/fragment/compose/AndroidFragment.kt
A fragment/fragment-compose/src/main/java/androidx/fragment/compose/FragmentState.kt
M fragment/fragment/api/current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransaction.java
M settings.gradle

https://android-review.googlesource.com/2989182

jb...@google.com <jb...@google.com> #6Aug 19, 2021 11:20PM

Marked as fixed.

Hey, Thanks to checking this out, I just checked this sample in the the repository, but this does not solve my issue.

I don't have access to the actual fragment class, we use an abstraction that just returns me a instance of Fragment with the arguments set, so this won't solve the issue for me, would it be possible to allow passing the Fragment instance ?

Issue 196871885