Make NavType name no longer abstract [196871885]

Fixed

Feature Request

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Aug 16, 2021 09:42PM

NavType should not require extended classes to override the name property. Name is used exclusively internal for NavInflater for classes that are inflated from XML. All the types that need to implement name already do, and custom NavTypes should not have this requirement.

Instead of being abstract, the name property should default to another string (i.e. "nav_type").

Comments

je...@gmail.com <je...@gmail.com> #2Aug 17, 2021 12:41AM

Nested scrolling works partially (as per

http://b/122818889). Let's discuss if we need full support and if so make sure it works.

ap...@google.com <ap...@google.com> #3Aug 18, 2021 08:02PM

Hi!

What is 'partially' exactly?
How do I see it?
Thanks!

ap...@google.com <ap...@google.com> #4Aug 19, 2021 10:25PM

As of now:
- Nesting scroll views with a scroll direction perpendicular to the ViewPager2's orientation inside ViewPager2 works
- Nesting scroll views with a scroll direction parallel to the ViewPager2's orientation inside ViewPager2 does not work

ap...@google.com <ap...@google.com> #5Aug 19, 2021 10:38PM

Horizontal ViewPager2 not correctly working into a vertical RecyclerView
Set a setNestedScrollingEnabled to the RecyclerView into the ViewPager2 (across reflection) resolves the problem

jb...@google.com <jb...@google.com> #6Aug 19, 2021 11:20PM

Marked as fixed.

ageevvalentin@gmail.com, could you provide a sample app? I'd like to learn more about the circumstances that cause the problem; putting a clean ViewPager2 inside a clean RecyclerView seems to work fine, so there must be other factors involved.

Issue 196871885