Status Update
Comments
ti...@gmail.com <ti...@gmail.com> #2
I see that this issue was assigned. I can create Pull Request if need.
il...@google.com <il...@google.com> #3
Feel free to do so and we will review.
ru...@gmail.com <ru...@gmail.com> #5
I think your PR also fixes our problem: we have links like
.../search/
.../search?documentId=123
.../search?folder=123
And each should be redirected to different navigation destinations. Currently they all redirect to one page, and sometimes crash.
il...@google.com <il...@google.com> #7
Thank you for the PR!
This has been fixed internally and will be available as part of the Navigation 2.4.0-alpha08
release.
jb...@google.com <jb...@google.com>
ap...@google.com <ap...@google.com> #8
Just a quick note. It seems like NavInflater don't set defaultValue when using android:defaultValue="@null" and thus the check will fail. You will have to add the query argument in your Uri : "
ap...@google.com <ap...@google.com> #9
I filed an issue RE: #8 ... an @null
default value should not be flagged as "required", and should not fail and cause the app to crash.
ap...@google.com <ap...@google.com> #10
Branch: androidx-main
commit 682bae8ada2b2b29376003d55455230ff7320a69
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 15:13:14 2023
Migrate accompanist NavGraphBuilder into androidx
Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "NavGraphBuilder now supports building composables and NavGraphs with transition animations."
Change-Id: I5ca9e22c8c3b02acaf80ddaa35b58ba7426c993a
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavGraphBuilder.kt
ap...@google.com <ap...@google.com> #11
Branch: androidx-main
commit 895c4bb35ee11fe1c54f538699a845ddfaf7e2eb
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 13:14:10 2023
Migrate accompanist ComposeNavigator into androidx
Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "ComposeNavigator now supports Destinations with Animations."
Change-Id: Ie33b4c2da53ff6c89494332a06be8123be67e879
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
ap...@google.com <ap...@google.com> #12
Branch: androidx-main
commit 169254301b8aad0454c253a65abff7bf174ba164
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 11:11:42 2023
Bump compose version in navigation-compose
Bump from 1.0.1 to ToT project dependency. Project dependency because compose is currently in alpha.
Test: n/a
Bug: 197140101
Relnote: "navigation-compose has bumped compose dependency to use latest compose dependency"
Change-Id: Ide442548636637c2b75d46ef99c9913b0ebb60b8
M navigation/navigation-compose/build.gradle
il...@google.com <il...@google.com> #13
Now that AnimatedContent
is stable, we were able to move the code from
This means all of the support for setting custom transitions that existed in AnimatedNavHost
is directly supported in NavHost
.
This is available in
We'll be publishing a deprecation guide once Navigation 2.7.0-alpha01 is released, but it'll be essentially the inverse of the 0.31.2-alpha
).
Description
As of compose Compose Animation APIs are still
1.0.1
many of the@Experimental
.Because of AndroidX internal restrictions, modules cannot depend on experimental APIs from other modules.
In the interest of providing a solution for Navigation with custom Compose Animations as soon as possible, we opted to provide a new module in Accompanist Navigation . Once all the required animation APIs become stable, which is planned as part of Compose
1.1.0
, we will move the implementation back into theJetpack Navigation library
fromAccompanist Navigation Animation
.For more details, see the Animations in Navigation Compose blog post.