Status Update
No update yet.
Comments
ra...@google.com
je...@google.com
ko...@gmail.com
As I understand it, we need to migrate namespace definitions both from AndroidManifest.xml and from implicit definitions from applicationId / testApplicationId? Is that right? So an 8.0 project would have a
namespace <n>
testNamespace <tn>
where <n> is taken from AndroidManifest.xml package definitions if present, and applicationId if not, and <tn> is testApplicationId if present and <n>.test if not?
im...@google.com
Sorry for the confusion. AGP would change how it computes the namespace for the androidTest variant. All the Upgrade assistant would need to do is update the source code for the import of the R class.
ka...@droidsonroids.pl
OK! And, I think, this should happen at the same time as the namespace declaration is migrated from AndroidManifest.xml?
im...@google.com
It's unrelated, but it is possible that we move 8.0 to also only declare the namespace into the DSL. I would make it a separate refactoring because they are not tied at all.
ko...@gmail.com
I would consider first adding the right new value to models (as a new property) and then, to avoid Studio interpreting manifests and build configurations, just update to whatever the synced value of this new property is.
im...@google.com
am...@google.com
am...@google.com
Updated version of this in #16 below
Currently, AUA removes the package attribute from the main manifest and instead specifies that value via the namespace DSL.
In addition to that, AUA should:
(1) Check for apackageattribute in the (possibly non-existent) androidTestAndroidManifest.xml. If there's a value there, it should be removed from that manifest, and if it's not equal tonamespace + ".test", it should be specified via thetestNamespaceDSL.Ifnamespace==testNamespace, this is problematic because the androidTest and regularRclasses will have the same namespace. Not sure what the best behavior is here? Maybe an error explaining that the user should first reset the androidTest AndroidManifest'spackageattribute and change the androidTest source code package accordingly?
- (2)
Compare the newtestNamespacewith the oldAndroidProject.androidTestNamespacefrom the model. If they are different, search the androidTest source code for references to anRclass namespaced withAndroidProejct.androidTestNamespace, and change the namespace totestNamespace.
am...@google.com
I have a draft implementation for the second part of (1) from namespace and testNamespace are equal. Is there any documentation we can point to explaining how the user should proceed? (My in-window space budget for explanatory text is pretty limited).
Description
We've used AGP 4.2.2 in project and all android tests under library modules worked fine. After upgrading AGP to version 7.0.0 (and later 7.0.1) we are not able to compile android tests.
For sample project call: ./gradlew :customView:assembleDebugAndroidTest
Result: > Cannot find resource: id view_1
Expected: Successful compilation
Changing AGP version in sample project to 4.2.2 solves issue.
Missing resource id is used in kotlin code as reference for Espresso.
Build: AI-203.7717.56.2031.7583922, 202107261959,
AI-203.7717.56.2031.7583922, JRE 11.0.10+0-b96-7281165x64 JetBrains s.r.o., OS Mac OS X(x86_64) v10.15.7, screens 2880.0x1800.0, 1920.0x1080.0
AS: Arctic Fox | 2020.3.1; Kotlin plugin: 203-1.5.21-release-328-AS7717.8; Android Gradle Plugin: 4.2.2; Gradle: 7.0.2; Gradle JDK: version 11.0.10; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)
IMPORTANT: Please read