Camera is closed when using Camerax on two successive screens [197539358]

Fixed

Bug

Status Update

No update yet.

Description

ni...@gmail.com

created issue #1

Aug 24, 2021 04:30PM

CAMERAX VERSION 1.1.0-alpha08, also in 1.0.0

DEVICE NAME: Pixel 4XL

DESCRIPTION: An app that display the camera on Screen A, then going to Screen B which also displays the camera. Screen B will be black if using the CameraController class to display the camera on the screen.

STEPS TO REPRODUCE: See sample here (in Compose, sorry) : https://github.com/NitroG42/CameraXSuccessiveCameraController

OBSERVED RESULTS: It seems that when going to the second screen, the lifecycle of first screen is destroyed and it closes the camera, which leaves the second screen in a bad state. When going back to the first screen, the camera is still closed.

EXPECTED RESULTS: The camera doesn't close if it's already used in a new screen.

REPRODUCIBILITY: Always

Comments

wu...@google.com <wu...@google.com> #2Aug 25, 2021 03:06AM

Project: platform/frameworks/support
Branch: androidx-main

commit b697d397d051f91a6f6ed95a55af421f048f3c89
Author: Sanura Njaka <sanura@google.com>
Date: Wed Aug 02 12:16:12 2023

Folding lifecycle-livedata-core-ktx back into main
module

Now that Lifecycle tests are written in kotlin, LiveDataTest
can be moved from lifecycle-livedata-core-ktx into LiveDataTest
within the main lifecycle-livedata-core module.

Test: ./gradlew bOS
Bug: 274800183
Change-Id: I98806ad751bd674a554de665e0e16bf05d67900d

D lifecycle/lifecycle-livedata-core-ktx/src/test/java/androidx/lifecycle/LiveDataTest.kt
M lifecycle/lifecycle-livedata-core/src/test/java/androidx/lifecycle/LiveDataTest.kt

https://android-review.googlesource.com/2690010

ni...@gmail.com <ni...@gmail.com> #3Aug 25, 2021 06:52AM

Project: platform/frameworks/support
Branch: androidx-main

commit cd3c1d7751462b5e42ae54e2d68299f955dcb6c3
Author: Sanura Njaka <sanura@google.com>
Date: Mon Aug 07 07:34:20 2023

Folding lifecycle-livedata-ktx back into main
module

Now that Lifecycle tests are written in kotlin, all files in lifecycle-livedata-ktx can now be added into the main lifecycle-livedata module.

RelNote: "All files from the lifecycle-livedata-ktx modules have been moved into the main lifecycle-livedata module"
Test: ./gradlew bOS
Bug: 274800183
Change-Id: I10c6f70c82a64e80eec704f548911f42bdd0b56a

M lifecycle/lifecycle-livedata-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata/api/current.txt
M lifecycle/lifecycle-livedata/api/restricted_current.txt
M lifecycle/lifecycle-livedata/build.gradle
M lifecycle/lifecycle-livedata/src/androidTest/java/androidx.lifecycle/FlowAsLiveDataIntegrationTest.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/FlowLiveData.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/FlowAsLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataAsFlowTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataFlowJavaTest.java
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/ScopesRule.kt

https://android-review.googlesource.com/2695173

ch...@google.com <ch...@google.com> Aug 27, 2021 09:46AM

Accepted by ch...@google.com.

ch...@google.com <ch...@google.com> #4Aug 31, 2021 03:29AM

Project: platform/frameworks/support
Branch: androidx-main

commit 32c1896b0506529674f03076a1141daaa0749b28
Author: Sanura Njaka <sanura@google.com>
Date: Tue Aug 22 11:20:50 2023

Moving ScopesRule into util package

ScopesRule.kt will now be included in lifecycle-livedata's util package

Test: ./gradlew bOS
BUg: 274800183
Change-Id: I2df34eebffcdacc716ce0235e29601436918f955

M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/FlowAsLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataAsFlowTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/util/ScopesRule.kt

https://android-review.googlesource.com/2721674

ch...@google.com <ch...@google.com> #5Aug 31, 2021 03:30AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4140c78328013f4fea4bd48f286c46a98c358270
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 14:43:43 2024

Move `lifecycle-viewmodel-ktx` source to the base module

* Transferred source code from `lifecycle-viewmodel-ktx` to the main `lifecycle-viewmodel` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
* Renamed the file from `ViewModel` to `ViewModelCoroutineScope` to reflect the content: coroutines support. Use `file:JvmName("ViewModelKt")` to maintain source compatibility.
* Add a resolutionStrategy to `:playground` and `:presentation` in `:tv:integration-tests` to resolve "minifyReleaseWithR8 FAILED: Class is defined multiple times" issue caused by moving classes from `-ktx` to the base module.

RelNote: "The `lifecycle-viewmodel-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: ViewModelCoroutinesTest
Change-Id: Id787b6db6817e69e4ec50748a07ccdbef074e99d

A lifecycle/lifecycle-viewmodel-ktx/api/current.ignore
M lifecycle/lifecycle-viewmodel-ktx/api/current.txt
A lifecycle/lifecycle-viewmodel-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-viewmodel-ktx/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-ktx/build.gradle
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/build.gradle
M lifecycle/lifecycle-viewmodel/src/androidTest/java/androidx/lifecycle/ViewModelCoroutineScopeTest.kt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelCoroutineScope.kt
M tv/integration-tests/playground/build.gradle
M tv/integration-tests/presentation/build.gradle

https://android-review.googlesource.com/2930010

dumpstate.zip

9.9 MB

Download

ap...@google.com <ap...@google.com> #6Sep 1, 2021 02:05AM

Project: platform/frameworks/support
Branch: androidx-main

commit ce327843c4c6bfeb3410a1203e0e2aac0f0a59cc
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 16:21:38 2024

Move `lifecycle-livedata-core-ktx` source to the base module

* Transferred source code from `lifecycle-livedata-core-ktx` to the base `lifecycle-livedata-core` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.

RelNote: "The `lifecycle-livedata-core-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: manual
Change-Id: I54a3d4346b4a9c5861f5f3bdb0079dbb27f29668

A lifecycle/lifecycle-livedata-core-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-core-ktx/api/current.txt
A lifecycle/lifecycle-livedata-core-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-core-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core-ktx/build.gradle
M lifecycle/lifecycle-livedata-core/api/current.txt
M lifecycle/lifecycle-livedata-core/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core/src/main/java/androidx/lifecycle/LiveData.kt

https://android-review.googlesource.com/2927827

ch...@google.com <ch...@google.com> #7Sep 1, 2021 02:10AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit b08ac008ee00cedd68d5f21a54c4035a7778c875
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Feb 07 11:19:04 2024

Move `lifecycle-runtime-ktx` source to the base module

* Transferred source code from `lifecycle-runtime-ktx` to the main `lifecycle-runtime` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
* Changed the method signature of `androidx.lifecycle.View.findViewTreeLifecycleOwner` from `View.findViewTreeLifecycleOwner()` to `findViewTreeLifecycleOwner(view)` to avoid a conflicting overload.
* Add a resolutionStrategy to `:playground` and `:presentation` in `:tv:integration-tests` to resolve "minifyReleaseWithR8 FAILED: Class is defined multiple times" issue caused by moving classes from `-ktx` to the base module.

RelNote: "The `lifecycle-runtime-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: FlowWithLifecycleTest
Test: LaunchWhenTest
Test: PausingDispatcherTest
Test: RepeatOnLifecycleTest
Test: ViewTreeLifecycleOwnerTest
Test: WithLifecycleStateTest
Change-Id: Ic368640a7e66dd0b748601d61b7aa23d99e5a1d6

D lifecycle/lifecycle-runtime-compose/api/current.ignore
D lifecycle/lifecycle-runtime-compose/api/restricted_current.ignore
A lifecycle/lifecycle-runtime-ktx/api/current.ignore
M lifecycle/lifecycle-runtime-ktx/api/current.txt
A lifecycle/lifecycle-runtime-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-runtime-ktx/api/restricted_current.txt
M lifecycle/lifecycle-runtime-ktx/build.gradle
D lifecycle/lifecycle-runtime-ktx/src/androidInstrumentedTest/kotlin/androidx/lifecycle/ViewTreeLifecycleOwnerTest.kt
M lifecycle/lifecycle-runtime/api/current.txt
M lifecycle/lifecycle-runtime/api/restricted_current.txt
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/Expectations.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/FakeLifecycleOwner.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/FlowWithLifecycleTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/LaunchWhenTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/PausingDispatcherTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/RepeatOnLifecycleTest.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/TaskTracker.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/TrackedExecutor.kt
M lifecycle/lifecycle-runtime/src/androidInstrumentedTest/kotlin/androidx/lifecycle/WithLifecycleStateTest.kt
M lifecycle/lifecycle-runtime/src/androidMain/AndroidManifest.xml
M lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/View.android.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/FlowExt.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/RepeatOnLifecycle.kt
M lifecycle/lifecycle-runtime/src/commonMain/kotlin/androidx/lifecycle/WithLifecycleState.kt
M tv/integration-tests/playground/build.gradle
M tv/integration-tests/presentation/build.gradle

https://android-review.googlesource.com/2928837