Inconsistent splash icon size on android 12 and on earlier version [197759820]

Fixed

Bug

core-splashscreen

Status Update

No update yet.

Description

fr...@gmail.com

created issue #1

Aug 26, 2021 01:05PM

Artifact used: androidx.core:core-splashscreen:1.0.0-alpha01 Version used: 1.0.0-alpha01 Theme used:

<style name="Theme.App.Starting" parent="Theme.SplashScreen">
    <item name="windowSplashScreenBackground">@color/purple_500</item>

    <item name="windowSplashScreenAnimatedIcon">@drawable/ic_baseline_adb_24</item>
    <item name="postSplashScreenTheme">@style/Theme.Playground</item>
</style>

<style name="Theme.Playground" parent="Theme.MaterialComponents.DayNight.DarkActionBar">
...
</style>

Devices/Android versions reproduced on: emulator with android 12 and android 6

When using the library, the splash icon looks quite different on:

Android 12 - the icon is enlarged and cropped by circle
Lower versions - icon is used as is

It would be nice to have same size of icon when using the library.

android-6.png

34 KB

View

Download

android-12.png

54 KB

View

Download

Comments

al...@google.com <al...@google.com> Aug 30, 2021 06:44PM

Assigned to ca...@google.com.

ap...@google.com <ap...@google.com> #2Sep 17, 2021 11:10AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 7d14fd070c7740087018b064c8f761432c3164ac
Author: Vadim Caen <caen@google.com>
Date: Wed Jul 21 19:58:00 2021

Support of splash screen icon background

- Added backward compatibility for the splash screen icon background.
- Also added minimal support API 21 to 23
- Fixes icon size and masking to match Android 12 behavior

Test: SplashScreenTests
Bug: 198161849
Fixes: 197759820
Fixes: 198165621
Relnote: "Added backward compatibility for the
windowSplashScreenIconBackgroundColor attribute"
Relnote: "Downgraded the minSdkVersion to API 21"

Change-Id: Idd05037fbc481ca80217c50b6e9bf64a16d90cd4

M core/core-splashscreen/src/androidTest/AndroidManifest.xml
A core/core-splashscreen/src/main/java/androidx/core/splashscreen/MaskedDrawable.kt
M core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashscreenParametrizedTest.kt
M core/core-splashscreen/src/androidTest/res/values/colors.xml
A core/core-splashscreen/src/main/res/drawable/icon_background.xml
M core/core-splashscreen/src/main/res/values/attrs.xml
M core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTestController.kt
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreenViewProvider.kt
M core/core-splashscreen/src/main/res/values-v31/styles.xml
A core/core-splashscreen/src/main/res/drawable-v23/compat_splash_screen_no_icon_background.xml
M core/core-splashscreen/src/main/res/layout/splash_screen_view.xml
M core/core-splashscreen/src/main/res/values/public.xml
M core/core-splashscreen/src/main/res/drawable-v23/compat_splash_screen.xml
M core/core-splashscreen/build.gradle
M core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTestActivities.kt
A core/core-splashscreen/src/main/res/drawable/compat_splash_screen_no_icon_background.xml
M core/core-splashscreen/src/main/res/values/dimens.xml
A core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTests.kt
M core/core-splashscreen/src/androidTest/res/drawable/android.xml
M core/core-splashscreen/src/main/res/values/styles.xml
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreen.kt
M core/core-splashscreen/api/res-current.txt
M core/core-splashscreen/src/androidTest/res/values/styles.xml
A core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTestUtils.kt

https://android-review.googlesource.com/1795729

Issue 197759820

Description

Issue summary

Comments

al...@google.com <al...@google.com> Aug 30, 2021 06:44PM

ap...@google.com <ap...@google.com> #2Sep 17, 2021 11:10AM

Add comment

Issue metadata