NPE in AndroidClipboardManager.getText [197769306]

Fixed

Bug

adexe s nau

Status Update

No update yet.

Description

ta...@mercury.com

created issue #1

Aug 25, 2021 08:34PM

Jetpack Compose release version: 1.0.1

Android Studio Build: 2021.1.1 Canary 9

Kotlin version: 1.5.21

This is a crash report received from a OnePlus Nord device running Android 11 (build AC2001_14_210704).

The action appears to be:

User switches to another app to copy a TOTP code
User returns to app and attempts to paste the code (possibly via long-press on the TextField)

Stack trace:

java.lang.NullPointerException
        at androidx.compose.ui.platform.AndroidClipboardManager.getText(AndroidClipboardManager.android.kt:2)
        at androidx.compose.foundation.text.selection.TextFieldSelectionManager.showSelectionToolbar$foundation_release(TextFieldSelectionManager.kt:14)
        at androidx.compose.foundation.text.CoreTextFieldKt.access$SelectionToolbarAndHandles(CoreTextField.kt:37)
        at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$4$1$1.invoke(CoreTextField.kt:41)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:6)
        at androidx.compose.foundation.text.selection.SimpleLayoutKt.SimpleLayout(SimpleLayout.kt:33)
        at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$4$1.invoke(CoreTextField.kt:38)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:6)
        at androidx.compose.material.OutlinedTextFieldKt.access$IconsWithTextFieldLayout-T2E5_Oc(OutlinedTextField.kt:114)
        at androidx.compose.material.OutlinedTextFieldKt$OutlinedTextFieldLayout$1.invoke(OutlinedTextField.kt:26)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:16)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:8)
        at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$$inlined$CoreTextFieldRootBox$1.invoke(CoreTextField.kt:5)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:6)
        at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:45)
        at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Composer.kt:6)
        at androidx.compose.foundation.text.ContextMenu_androidKt.ContextMenuArea(ContextMenu.android.kt:2)
        at androidx.compose.foundation.text.CoreTextFieldKt.CoreTextField(CoreTextField.kt:239)
        at androidx.compose.foundation.text.BasicTextFieldKt.BasicTextField(BasicTextField.kt:40)
        at androidx.compose.material.OutlinedTextFieldKt.OutlinedTextFieldLayout-uBqXD2s(OutlinedTextField.kt:22)
        at androidx.compose.material.TextFieldImplKt$TextFieldImpl$1.invoke(TextFieldImpl.kt:47)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:30)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:10)
        at androidx.compose.material.TextFieldTransitionScope.Transition(TextFieldImpl.kt:73)
        at androidx.compose.material.TextFieldTransitionScope$Transition$1.invoke(TextFieldImpl.kt:1)
        at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:45)
        at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(Composer.kt:10)
        at androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:35)
        at androidx.compose.runtime.ComposerImpl.recompose$runtime_release(Composer.kt:4)
        at androidx.compose.runtime.CompositionImpl.recompose(Composition.kt:7)
        at androidx.compose.runtime.Recomposer.access$performRecompose(Recomposer.kt:8)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:40)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:1)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:14)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1350)
        at android.view.Choreographer.doCallbacks(Choreographer.java:1149)
        at android.view.Choreographer.doFrame(Choreographer.java:1040)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1333)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:245)
        at android.app.ActivityThread.main(ActivityThread.java:8004)
        at java.lang.reflect.Method.invoke(Method.java:-2)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:631)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:978)

Comments

je...@google.com <je...@google.com> Aug 26, 2021 10:06AM

Assigned to ha...@google.com.

ha...@google.com <ha...@google.com> Nov 29, 2021 06:04AM

Reassigned to an...@google.com.

[Deleted User] <[Deleted User]> #2Feb 16, 2022 07:25AM

We see this crash (with a slightly different stack trace) as one of our most common ones as well within Google Play Console. It happens for different devices and for different Android versions. We use compose 1.1.0-rc03.

I think the problem is that the AndroidClipboardManager.getText() is not really thread safe and maybe the primary clip changed between hasPrimaryClip() and clipboardManager.primaryClip!!.getItemAt(0).text.convertToAnnotatedString(). Maybe simply using a let like clipboardManager.primaryClip?.let { getItemAt(0).text.convertToAnnotatedString() } would fix the issue.

java.lang.NullPointerException: 
  at androidx.compose.ui.platform.AndroidClipboardManager.getText (AndroidClipboardManager.android.kt:65)
  at androidx.compose.foundation.text.selection.TextFieldSelectionManager.showSelectionToolbar$foundation_release (TextFieldSelectionManager.kt:581)
  at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$onPositionedModifier$1.invoke (CoreTextField.kt:342)
  at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$onPositionedModifier$1.invoke (CoreTextField.kt:337)
  at androidx.compose.ui.layout.OnGloballyPositionedModifierImpl.onGloballyPositioned (OnGloballyPositionedModifier.kt:58)
  at androidx.compose.ui.node.LayoutNode.dispatchOnPositionedCallbacks$ui_release (LayoutNode.kt:1186)
  at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:51)
  at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:55)
  at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:55)
  at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:55)
  at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:55)
  at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:55)
  at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:55)
  at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:55)
  at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:55)
  at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:55)
  at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:55)
  at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:55)
  at androidx.compose.ui.node.OnPositionedDispatcher.dispatch (OnPositionedDispatcher.kt:44)
  at androidx.compose.ui.node.MeasureAndLayoutDelegate.dispatchOnPositionedCallbacks (MeasureAndLayoutDelegate.kt:302)
  at androidx.compose.ui.node.MeasureAndLayoutDelegate.dispatchOnPositionedCallbacks$default (MeasureAndLayoutDelegate.kt:298)
  at androidx.compose.ui.platform.AndroidComposeView.measureAndLayout (AndroidComposeView.android.kt:666)
  at androidx.compose.ui.node.Owner$DefaultImpls.measureAndLayout$default (Owner.kt:182)
  at androidx.compose.ui.platform.AndroidComposeView.dispatchDraw (AndroidComposeView.android.kt:846)
  at android.view.View.draw (View.java:22654)
  at android.view.View.updateDisplayListIfDirty (View.java:21475)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4579)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4552)
  at android.view.View.updateDisplayListIfDirty (View.java:21425)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4579)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4552)
  at android.view.View.updateDisplayListIfDirty (View.java:21425)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4579)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4552)
  at android.view.View.updateDisplayListIfDirty (View.java:21425)
  at android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4579)
  at android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4552)
  at android.view.View.updateDisplayListIfDirty (View.java:21425)
  at android.view.ThreadedRenderer.updateViewTreeDisplayList (ThreadedRenderer.java:559)
  at android.view.ThreadedRenderer.updateRootDisplayList (ThreadedRenderer.java:565)
  at android.view.ThreadedRenderer.draw (ThreadedRenderer.java:642)
  at android.view.ViewRootImpl.draw (ViewRootImpl.java:4344)
  at android.view.ViewRootImpl.performDraw (ViewRootImpl.java:4054)
  at android.view.ViewRootImpl.performTraversals (ViewRootImpl.java:3312)
  at android.view.ViewRootImpl.doTraversal (ViewRootImpl.java:2114)
  at android.view.ViewRootImpl$TraversalRunnable.run (ViewRootImpl.java:8581)
  at android.view.Choreographer$CallbackRecord.run (Choreographer.java:975)
  at android.view.Choreographer.doCallbacks (Choreographer.java:799)
  at android.view.Choreographer.doFrame (Choreographer.java:734)
  at android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:960)
  at android.os.Handler.handleCallback (Handler.java:938)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loop (Looper.java:236)
  at android.app.ActivityThread.main (ActivityThread.java:7864)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:620)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1011)

si...@google.com <si...@google.com> #3Feb 16, 2022 11:06PM

Thank you for the report. We will take a look at this as soon as possible.

se...@google.com <se...@google.com> Feb 17, 2022 12:17AM

Reassigned to se...@google.com.

ap...@google.com <ap...@google.com> #4Feb 17, 2022 10:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7f6930f31af3bec42064a14d676339fcb011346b
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Feb 16 16:55:02 2022

Fix crash in AndroidClipboardManager

getText previously read primaryClip twice, which may become null between
calls for various reasons.

Relnote: "Fix crash caused by clipboard content while reading from
clipboard on Android."
Bug:

b/197769306

Test: ./gradlew :compose:ui:ui:cAT

Change-Id: I0602066750e3fce55deceb709f8c04ee9a71dabf

M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidClipboardManager.android.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/platform/AndroidClipboardManagerTest.kt

https://android-review.googlesource.com/1989811

se...@google.com <se...@google.com> Feb 23, 2022 11:21PM

Marked as fixed.

na...@google.com <na...@google.com> #5Oct 24, 2022 01:36PM

The following release(s) address this bug:

androidx.compose.ui:ui:1.3.0