Fixed
Status Update
Comments
si...@google.com <si...@google.com>
se...@google.com <se...@google.com> #2
Thank you for the report!
Yep 🤦
Fix coming in the next alpha!
Yep 🤦
Fix coming in the next alpha!
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 3263f781892c40ca3313d233795bcf8ec9bd13a9
Author: Sean McQuillan <seanmcq@google.com>
Date: Mon Aug 30 15:09:43 2021
Emoji2: Use correct helper on API 19 and 28
This fixes DefaultEmojiCompatConfig to use the correct helper on API 19
and API 28. Previously, this would use the helper for the API level
below on these levels.
Relnote: "Fix DefaultEmojiCompatConfig to correctly lookup emoji font
provider on API 19 and 28. This fixes a bug introduced in emoji2
1.0.0-alpha01."
Bug: b/197906329
Test: :e2:e2:cAT
Change-Id: Ib33d84de2a030f6e57e3d5382a088255a202692a
M emoji2/emoji2/src/androidTest/java/androidx/emoji2/text/DefaultEmojiCompatConfigTest.java
M emoji2/emoji2/src/main/java/androidx/emoji2/text/DefaultEmojiCompatConfig.java
https://android-review.googlesource.com/1814110
Branch: androidx-main
commit 3263f781892c40ca3313d233795bcf8ec9bd13a9
Author: Sean McQuillan <seanmcq@google.com>
Date: Mon Aug 30 15:09:43 2021
Emoji2: Use correct helper on API 19 and 28
This fixes DefaultEmojiCompatConfig to use the correct helper on API 19
and API 28. Previously, this would use the helper for the API level
below on these levels.
Relnote: "Fix DefaultEmojiCompatConfig to correctly lookup emoji font
provider on API 19 and 28. This fixes a bug introduced in emoji2
1.0.0-alpha01."
Bug:
Test: :e2:e2:cAT
Change-Id: Ib33d84de2a030f6e57e3d5382a088255a202692a
M emoji2/emoji2/src/androidTest/java/androidx/emoji2/text/DefaultEmojiCompatConfigTest.java
M emoji2/emoji2/src/main/java/androidx/emoji2/text/DefaultEmojiCompatConfig.java
Description
Component used:
DefaultEmojiCompatConfig.DefaultEmojiCompatConfigFactory#getHelperForApi()
Version used: 1.0.0-alpha3
Devices/Android versions reproduced on: -
The
getHelperForApi()
-function looks like this:Because the helpers actually support APIs 19 and 28, respectively, I think, the conditions should be
>=
instead of>
.