ActionCallback for TextToolbar in internal: difficult to override [197950089]

Fixed

Bug

Status Update

No update yet.

Description

ph...@gmail.com

created issue #1

Aug 28, 2021 04:42PM

Jetpack Compose release version: 1.0.1

I'd like to implement object for TextToolbar interface to present custom text toolbar. I'm doing it like this:

class CustomTextToolbar(private val view: View) : TextToolbar {
    override fun hide() {
        println("hide")
    }

    override val status: TextToolbarStatus = TextToolbarStatus.Hidden

    override fun showMenu(
        rect: Rect,
        onCopyRequested: ActionCallback?,
        onPasteRequested: ActionCallback?,
        onCutRequested: ActionCallback?,
        onSelectAllRequested: ActionCallback?
    ) {
        println("showMenu")
    }
}

But I'm getting next error:

Cannot access 'ActionCallback': it is internal in 'androidx.compose.ui.platform'

I was able to fix it by implementing typealias with the same name

typealias ActionCallback = () -> Unit

But I think it's a mistake, and it should be public.

Comments

ma...@google.com <ma...@google.com> #2Sep 14, 2021 01:49PM

Assigned to se...@google.com.

Over to Sean to triage appropriately.

We need to remove internal typealias from public APIs.

xu...@gmail.com <xu...@gmail.com> #3Mar 1, 2022 04:21PM

Is there a plan to fix it?

se...@google.com <se...@google.com> #4Mar 1, 2022 10:19PM

Marked as fixed.

In text release.

ap...@google.com <ap...@google.com> #5Mar 2, 2022 05:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit 044ee82a4c1d0e4ca8fce039c535aa684baabc9d
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Mar 01 14:10:13 2022

Remove exposed internal ActionCallback typealias

Previously TextToolbar exposed ActionCallback on parameters of
public open methods.

This was never satisfyable without introducing a parallel typealias, as
it was internal.

This removes ActionCallback and replaces all usages with the type.

Bug:

b/197950089

Test: No code changes (inline typealias)
Relnote: "TextToolbar now takes lambda arguments instead of
ActionCallback fixing

b/197950089

"

Change-Id: Ib2eb9d370cd6a22bbfbdec0d2cb536302ea43d6a

M compose/ui/ui/api/restricted_current.ignore
M compose/ui/ui/api/current.ignore
M compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/DefaultTextToolbar.skiko.kt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/TextToolbar.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidTextToolbar.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/actionmodecallback/TextActionModeCallback.android.kt
M compose/ui/ui/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2004851

Issue 197950089

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> #2Sep 14, 2021 01:49PM

xu...@gmail.com <xu...@gmail.com> #3Mar 1, 2022 04:21PM

se...@google.com <se...@google.com> #4Mar 1, 2022 10:19PM

ap...@google.com <ap...@google.com> #5Mar 2, 2022 05:23PM

Add comment

Issue metadata