ActionCallback for TextToolbar in internal: difficult to override [197950089]

Fixed

Bug

Status Update

No update yet.

Description

ph...@gmail.com

created issue #1

Aug 28, 2021 04:42PM

Jetpack Compose release version: 1.0.1

I'd like to implement object for TextToolbar interface to present custom text toolbar. I'm doing it like this:

class CustomTextToolbar(private val view: View) : TextToolbar {
    override fun hide() {
        println("hide")
    }

    override val status: TextToolbarStatus = TextToolbarStatus.Hidden

    override fun showMenu(
        rect: Rect,
        onCopyRequested: ActionCallback?,
        onPasteRequested: ActionCallback?,
        onCutRequested: ActionCallback?,
        onSelectAllRequested: ActionCallback?
    ) {
        println("showMenu")
    }
}

But I'm getting next error:

Cannot access 'ActionCallback': it is internal in 'androidx.compose.ui.platform'

I was able to fix it by implementing typealias with the same name

typealias ActionCallback = () -> Unit

But I think it's a mistake, and it should be public.

Comments

ma...@google.com <ma...@google.com> #2Sep 14, 2021 01:49PM

Assigned to se...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

xu...@gmail.com <xu...@gmail.com> #3Mar 1, 2022 04:21PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

se...@google.com <se...@google.com> #4Mar 1, 2022 10:19PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ap...@google.com <ap...@google.com> #5Mar 2, 2022 05:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit 044ee82a4c1d0e4ca8fce039c535aa684baabc9d
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Mar 01 14:10:13 2022

Remove exposed internal ActionCallback typealias

Previously TextToolbar exposed ActionCallback on parameters of
public open methods.

This was never satisfyable without introducing a parallel typealias, as
it was internal.

This removes ActionCallback and replaces all usages with the type.

Bug:

b/197950089

Test: No code changes (inline typealias)
Relnote: "TextToolbar now takes lambda arguments instead of
ActionCallback fixing

b/197950089

"

Change-Id: Ib2eb9d370cd6a22bbfbdec0d2cb536302ea43d6a

M compose/ui/ui/api/restricted_current.ignore
M compose/ui/ui/api/current.ignore
M compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/DefaultTextToolbar.skiko.kt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/TextToolbar.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidTextToolbar.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/actionmodecallback/TextActionModeCallback.android.kt
M compose/ui/ui/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2004851

Issue 197950089

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> #2Sep 14, 2021 01:49PM

xu...@gmail.com <xu...@gmail.com> #3Mar 1, 2022 04:21PM

se...@google.com <se...@google.com> #4Mar 1, 2022 10:19PM

ap...@google.com <ap...@google.com> #5Mar 2, 2022 05:23PM

Add comment

Issue metadata