Status Update
Comments
sa...@gmail.com <sa...@gmail.com> #2
be...@google.com <be...@google.com> #3
Hello there,
Ok, after reviewing the docs on the page for
"If you cache node_modules rather than running yarn install every time, make sure that the patches dir is included in your cache key somehow. Otherwise if you update a patch then the change may not be reflected on subsequent CI runs."
I believe this would be applicable to App Engine, Cloud Functions, and Cloud Run. App Engine yarn.lock
filespackage-lock.json
files as another alternative to yarn.lock
package-lock.json
as an alternative when using Node.js.
Nevertheless, I believe this is expected/intended for patch-package, as after re-reading the contents of the Docker/CI section above, the second bullet point (prior to the third one I mentioned) states that you should copy the patch files created by the library before running npm install (it states that you should modify the Dockerfile).
I apologize if this response is a little late, if you'd like a little bit of help with the Dockerfile I can certainly help out as a best effort; and if you still think that this specific library should be something we somehow integrate within our existing systems, I'll forward your request to the appropriate team so that they can approve or deny the request. Do note that even if it is approved, there is no ETA for the implementation of said feature.
Kind regards
be...@google.com <be...@google.com> #4
Hello again,
As there's been no response to this feature request (be it a commment or even having it be starred), and it is my understanding that this is intended (or at least expected) behavior by patch-package, I will be closing this under the status Won't fix (intended behavior)
. Should anyone find this to be an issue for them, please create a new issue and add this issue under "Blocked By" so that the issues are linked and there's a history for people reviewing the feature to follow.
Kind regards
sa...@gmail.com <sa...@gmail.com> #5
First, a huge thanks to have spent time on the issue!!
I am not at all familiar with Docker, yarn files, etc, so I will first have
to spend some time catching up.
After that, if I'm still stuck, I will reopen this issue if I think it is
necessary (although it's probably just tinkering with CI files, as you
said).
Thanks again!!
On Wed, 15 Sept 2021 at 22:28, <buganizer-system@google.com> wrote:
Description
Hi,
I've been using the npm package
patch-package
to apply patches insidenode_modules
, and this was working when I was using AWS EBS, but this does not work anymore after migrating to Google App Engine (as a workaround I needed to copy my patched version in a separate directory).Even if the workaround exists, it would be great to be able to use
patch-package
, and that would both ease the development and ease the migration from AWS of any project that already uses it.Kind Regards,
Samuel Amo