Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 05a6628dabeea8f0ae184a4d21add8656797bfd6
Author: Vadim Caen <caen@google.com>
Date: Mon Aug 30 19:19:02 2021
Update SplashScreenSample to use an icon background
Test: N/A
Bug: 198161849
Change-Id: I387ef638cd3ea485d9cd826608bb94394508359c
M core/core-splashscreen/samples/src/main/res/values/aliases.xml
M core/core-splashscreen/samples/src/main/res/drawable-v26/ic_launcher.xml
D core/core-splashscreen/samples/src/main/res/drawable/splashscreen_icon.xml
M core/core-splashscreen/samples/src/main/AndroidManifest.xml
M core/core-splashscreen/samples/src/main/res/values/styles.xml
M core/core-splashscreen/samples/src/main/res/drawable/ic_launcher.xml
M core/core-splashscreen/samples/src/main/res/drawable/android.xml
M core/core-splashscreen/samples/src/main/res/values/colors.xml
https://android-review.googlesource.com/1813996
Branch: androidx-main
commit 05a6628dabeea8f0ae184a4d21add8656797bfd6
Author: Vadim Caen <caen@google.com>
Date: Mon Aug 30 19:19:02 2021
Update SplashScreenSample to use an icon background
Test: N/A
Bug: 198161849
Change-Id: I387ef638cd3ea485d9cd826608bb94394508359c
M core/core-splashscreen/samples/src/main/res/values/aliases.xml
M core/core-splashscreen/samples/src/main/res/drawable-v26/ic_launcher.xml
D core/core-splashscreen/samples/src/main/res/drawable/splashscreen_icon.xml
M core/core-splashscreen/samples/src/main/AndroidManifest.xml
M core/core-splashscreen/samples/src/main/res/values/styles.xml
M core/core-splashscreen/samples/src/main/res/drawable/ic_launcher.xml
M core/core-splashscreen/samples/src/main/res/drawable/android.xml
M core/core-splashscreen/samples/src/main/res/values/colors.xml
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 7d14fd070c7740087018b064c8f761432c3164ac
Author: Vadim Caen <caen@google.com>
Date: Wed Jul 21 19:58:00 2021
Support of splash screen icon background
- Added backward compatibility for the splash screen icon background.
- Also added minimal support API 21 to 23
- Fixes icon size and masking to match Android 12 behavior
Test: SplashScreenTests
Bug: 198161849
Fixes: 197759820
Fixes: 198165621
Relnote: "Added backward compatibility for the
windowSplashScreenIconBackgroundColor attribute"
Relnote: "Downgraded the minSdkVersion to API 21"
Change-Id: Idd05037fbc481ca80217c50b6e9bf64a16d90cd4
M core/core-splashscreen/src/androidTest/AndroidManifest.xml
A core/core-splashscreen/src/main/java/androidx/core/splashscreen/MaskedDrawable.kt
M core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashscreenParametrizedTest.kt
M core/core-splashscreen/src/androidTest/res/values/colors.xml
A core/core-splashscreen/src/main/res/drawable/icon_background.xml
M core/core-splashscreen/src/main/res/values/attrs.xml
M core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTestController.kt
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreenViewProvider.kt
M core/core-splashscreen/src/main/res/values-v31/styles.xml
A core/core-splashscreen/src/main/res/drawable-v23/compat_splash_screen_no_icon_background.xml
M core/core-splashscreen/src/main/res/layout/splash_screen_view.xml
M core/core-splashscreen/src/main/res/values/public.xml
M core/core-splashscreen/src/main/res/drawable-v23/compat_splash_screen.xml
M core/core-splashscreen/build.gradle
M core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTestActivities.kt
A core/core-splashscreen/src/main/res/drawable/compat_splash_screen_no_icon_background.xml
M core/core-splashscreen/src/main/res/values/dimens.xml
A core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTests.kt
M core/core-splashscreen/src/androidTest/res/drawable/android.xml
M core/core-splashscreen/src/main/res/values/styles.xml
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreen.kt
M core/core-splashscreen/api/res-current.txt
M core/core-splashscreen/src/androidTest/res/values/styles.xml
A core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTestUtils.kt
https://android-review.googlesource.com/1795729
Branch: androidx-main
commit 7d14fd070c7740087018b064c8f761432c3164ac
Author: Vadim Caen <caen@google.com>
Date: Wed Jul 21 19:58:00 2021
Support of splash screen icon background
- Added backward compatibility for the splash screen icon background.
- Also added minimal support API 21 to 23
- Fixes icon size and masking to match Android 12 behavior
Test: SplashScreenTests
Bug: 198161849
Fixes: 197759820
Fixes: 198165621
Relnote: "Added backward compatibility for the
windowSplashScreenIconBackgroundColor attribute"
Relnote: "Downgraded the minSdkVersion to API 21"
Change-Id: Idd05037fbc481ca80217c50b6e9bf64a16d90cd4
M core/core-splashscreen/src/androidTest/AndroidManifest.xml
A core/core-splashscreen/src/main/java/androidx/core/splashscreen/MaskedDrawable.kt
M core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashscreenParametrizedTest.kt
M core/core-splashscreen/src/androidTest/res/values/colors.xml
A core/core-splashscreen/src/main/res/drawable/icon_background.xml
M core/core-splashscreen/src/main/res/values/attrs.xml
M core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTestController.kt
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreenViewProvider.kt
M core/core-splashscreen/src/main/res/values-v31/styles.xml
A core/core-splashscreen/src/main/res/drawable-v23/compat_splash_screen_no_icon_background.xml
M core/core-splashscreen/src/main/res/layout/splash_screen_view.xml
M core/core-splashscreen/src/main/res/values/public.xml
M core/core-splashscreen/src/main/res/drawable-v23/compat_splash_screen.xml
M core/core-splashscreen/build.gradle
M core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTestActivities.kt
A core/core-splashscreen/src/main/res/drawable/compat_splash_screen_no_icon_background.xml
M core/core-splashscreen/src/main/res/values/dimens.xml
A core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTests.kt
M core/core-splashscreen/src/androidTest/res/drawable/android.xml
M core/core-splashscreen/src/main/res/values/styles.xml
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreen.kt
M core/core-splashscreen/api/res-current.txt
M core/core-splashscreen/src/androidTest/res/values/styles.xml
A core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTestUtils.kt
ca...@google.com <ca...@google.com>
ka...@outlook.de <ka...@outlook.de> #4
Wouldn't it make sense to support drawables as windowSplashScreenIconBackground? E.g. sth. like windowSplashScreenIconBackgroundDrawable?
ca...@google.com <ca...@google.com> #5
I was a design decision to only support solid colors on Android 12.
sn...@gmail.com <sn...@gmail.com> #6
<item name="windowSplashScreenAnimatedIcon">@drawable/ic_splash_screen_logo</item>
Splash screen icon is not being shown on android 21 & 22.
Splash screen icon is not being shown on android 21 & 22.
Description
Add backward support for windowSplashScreenIconBackgroundColor