Add support for windowSplashScreenIconBackgroundColor [198161849]

Fixed

Feature Request

core-splashscreen

Status Update

No update yet.

Description

ca...@google.com

created issue #1

Aug 30, 2021 05:16PM

Add backward support for windowSplashScreenIconBackgroundColor

Comments

ap...@google.com <ap...@google.com> #2Sep 17, 2021 11:10AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Sep 17, 2021 11:10AM

Project: platform/frameworks/support
Branch: androidx-main

commit 7d14fd070c7740087018b064c8f761432c3164ac
Author: Vadim Caen <caen@google.com>
Date: Wed Jul 21 19:58:00 2021

Support of splash screen icon background

- Added backward compatibility for the splash screen icon background.
- Also added minimal support API 21 to 23
- Fixes icon size and masking to match Android 12 behavior

Test: SplashScreenTests
Bug: 198161849
Fixes: 197759820
Fixes: 198165621
Relnote: "Added backward compatibility for the
windowSplashScreenIconBackgroundColor attribute"
Relnote: "Downgraded the minSdkVersion to API 21"

Change-Id: Idd05037fbc481ca80217c50b6e9bf64a16d90cd4

M core/core-splashscreen/src/androidTest/AndroidManifest.xml
A core/core-splashscreen/src/main/java/androidx/core/splashscreen/MaskedDrawable.kt
M core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashscreenParametrizedTest.kt
M core/core-splashscreen/src/androidTest/res/values/colors.xml
A core/core-splashscreen/src/main/res/drawable/icon_background.xml
M core/core-splashscreen/src/main/res/values/attrs.xml
M core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTestController.kt
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreenViewProvider.kt
M core/core-splashscreen/src/main/res/values-v31/styles.xml
A core/core-splashscreen/src/main/res/drawable-v23/compat_splash_screen_no_icon_background.xml
M core/core-splashscreen/src/main/res/layout/splash_screen_view.xml
M core/core-splashscreen/src/main/res/values/public.xml
M core/core-splashscreen/src/main/res/drawable-v23/compat_splash_screen.xml
M core/core-splashscreen/build.gradle
M core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTestActivities.kt
A core/core-splashscreen/src/main/res/drawable/compat_splash_screen_no_icon_background.xml
M core/core-splashscreen/src/main/res/values/dimens.xml
A core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTests.kt
M core/core-splashscreen/src/androidTest/res/drawable/android.xml
M core/core-splashscreen/src/main/res/values/styles.xml
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/SplashScreen.kt
M core/core-splashscreen/api/res-current.txt
M core/core-splashscreen/src/androidTest/res/values/styles.xml
A core/core-splashscreen/src/androidTest/java/androidx/core/splashscreen/test/SplashScreenTestUtils.kt

https://android-review.googlesource.com/1795729

ca...@google.com <ca...@google.com> Sep 17, 2021 11:20AM

Marked as fixed.

ka...@outlook.de <ka...@outlook.de> #4Oct 7, 2021 11:03AM

Wouldn't it make sense to support drawables as windowSplashScreenIconBackground? E.g. sth. like windowSplashScreenIconBackgroundDrawable?

ca...@google.com <ca...@google.com> #5Oct 11, 2021 08:35AM

I was a design decision to only support solid colors on Android 12.

sn...@gmail.com <sn...@gmail.com> #6Jan 18, 2022 12:09PM

<item name="windowSplashScreenAnimatedIcon">@drawable/ic_splash_screen_logo</item>
Splash screen icon is not being shown on android 21 & 22.

Issue 198161849