Mouse scroll events are not supported in compose [198214718]

Fixed

Feature Request

Status Update

No update yet.

Description

mo...@google.com

created issue #1

Aug 31, 2021 12:15AM

Compose must support mouse scroll wheel events.

Comments

mo...@google.com <mo...@google.com> #2Oct 11, 2021 09:09PM

Reassigned to ma...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6492a281bd17da7537f453a3fc01d182c79a169e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Jul 27 17:24:43 2020

Rename BottomNavigationItem parameters

text -> label to match the Material.io documentation and the `alwaysShowLabels` parameter
onSelected -> onSelect to match the tense we use in other components
activeColor -> selectedContentColor to be more clear about what this 'color' is, and match the selected state
inactiveColor -> unselectedContentColor to be more clear about waht this 'color' is, and match the not-selected state

Additionally fixes the ordering of parameters so that all required parameters are first, followed by the Modifier param.

Bug:

b/161809324

Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's `text` parameter to `label`, `onSelected` to `onSelect`, `activeColor` to `selectedContentColor`, `inactiveColor` to `unselectedContentColor` and updates parameter ordering to match guidelines."
Change-Id: Icb605dac9b76a0204a2a9d675530da8897f817d5

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt

https://android-review.googlesource.com/1373097

ma...@google.com <ma...@google.com> #3Oct 14, 2021 02:24PM

Discussed further offline, onSelect should be renamed to onClick for consistency (with Tab and other components).

ap...@google.com <ap...@google.com> #4Nov 18, 2021 11:43AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit dfd1e72afa17243e42449e955f08213f0a4afcd4
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Wed Sep 09 17:04:47 2020

Renames BottomNavigationItem's onSelect parameter to onClick for consistency with other components such as Tab

Bug:

b/161809324

Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's onSelect parameter to onClick"
Change-Id: I919251069ab307d1ed5c1c3fbf5a01bf77a85047

M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt

https://android-review.googlesource.com/1423472

je...@gmail.com <je...@gmail.com> #5Dec 8, 2021 05:36PM

The sample app from duplicate issue 205373134 (https://issuetracker.google.com/issues/205373134) still does not work with Compose 1.1.0-beta04

Did this fix get applied to Compose 1.1.0-beta04? (commit "compose/ui/ui/api/public_plus_experimental_1.1.0-beta04.txt" makes it seem like this fix was targeting Compose 1.1.0-beta04)

ma...@google.com <ma...@google.com> #6Dec 8, 2021 05:48PM

The fix above has added low level support of the PointerEvents, allowing people to handle mouse events manually. We don't support yet the mouse scroll in LazyColumn, it would be available in versions starting with 1.2.x.

Apologies it the closure of the bug caused some confusion. I reoponed the issue you linked and remove the "duplication".

you can follow the resolution here as well: https://android-review.googlesource.com/c/platform/frameworks/support/+/1837304

ap...@google.com <ap...@google.com> #7Jan 13, 2022 06:33PM

Project: platform/frameworks/support
Branch: androidx-main

commit 163e2469c85eedf0604a9a90abfebd606fee9ab2
Author: Matvei Malkov <malkov@google.com>
Date: Fri Sep 24 17:45:50 2021

Mouse wheel scrolling in Modifier.scrollable

Prototype CL that makes the lazy/simple effort to support mouse wheel in common code for high-level Modifier.scrollable.

Bug: 198214718
Test: Added new tests for scrolling, consumption and nested scroll (the absence of it)
Relnote: LazyColumn, LazyRow, Modifier.verticalScroll and other containers that use Modifier.scrollable now support mouse wheel scrolling.
Change-Id: I2b5e15f480a26878e8dc8727e34d6e7ec660e564

M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/gestures/AndroidScrollable.android.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
M compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/ScrollbarTest.kt
M compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/gestures/DesktopScrollable.desktop.kt
M compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/gestures/DesktopScrollableTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt

https://android-review.googlesource.com/1837304

Issue 198214718