Mouse scroll events are not supported in compose [198214718]

Fixed

Feature Request

Status Update

No update yet.

Description

mo...@google.com

created issue #1

Aug 31, 2021 12:15AM

Compose must support mouse scroll wheel events.

Comments

mo...@google.com <mo...@google.com> #2Oct 11, 2021 09:09PM

Reassigned to ma...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ma...@google.com <ma...@google.com> #3Oct 14, 2021 02:24PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ap...@google.com <ap...@google.com> #4Nov 18, 2021 11:43AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

je...@gmail.com <je...@gmail.com> #5Dec 8, 2021 05:36PM

The sample app from duplicate issue 205373134 (https://issuetracker.google.com/issues/205373134) still does not work with Compose 1.1.0-beta04

Did this fix get applied to Compose 1.1.0-beta04? (commit "compose/ui/ui/api/public_plus_experimental_1.1.0-beta04.txt" makes it seem like this fix was targeting Compose 1.1.0-beta04)

ma...@google.com <ma...@google.com> #6Dec 8, 2021 05:48PM

The fix above has added low level support of the PointerEvents, allowing people to handle mouse events manually. We don't support yet the mouse scroll in LazyColumn, it would be available in versions starting with 1.2.x.

Apologies it the closure of the bug caused some confusion. I reoponed the issue you linked and remove the "duplication".

you can follow the resolution here as well: https://android-review.googlesource.com/c/platform/frameworks/support/+/1837304

ap...@google.com <ap...@google.com> #7Jan 13, 2022 06:33PM

Project: platform/frameworks/support
Branch: androidx-main

commit 163e2469c85eedf0604a9a90abfebd606fee9ab2
Author: Matvei Malkov <malkov@google.com>
Date: Fri Sep 24 17:45:50 2021

Mouse wheel scrolling in Modifier.scrollable

Prototype CL that makes the lazy/simple effort to support mouse wheel in common code for high-level Modifier.scrollable.

Bug: 198214718
Test: Added new tests for scrolling, consumption and nested scroll (the absence of it)
Relnote: LazyColumn, LazyRow, Modifier.verticalScroll and other containers that use Modifier.scrollable now support mouse wheel scrolling.
Change-Id: I2b5e15f480a26878e8dc8727e34d6e7ec660e564

M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/gestures/AndroidScrollable.android.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
M compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/ScrollbarTest.kt
M compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/gestures/DesktopScrollable.desktop.kt
M compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/gestures/DesktopScrollableTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt

https://android-review.googlesource.com/1837304

Issue 198214718