Make parameters with defaults last in generated arguments [198493585]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Sep 1, 2021 10:38PM

In Navigation 2.4.0-alpha08 https://issuetracker.google.com/188855904 made generated directions classes make default parameters last to match Kotlin coding style. We should also do the same for generated arguments.

Comments

ap...@google.com <ap...@google.com> #2Sep 1, 2021 11:21PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 42d5037be3a80f5ff840eee1f0a74bfb8f287d66
Author: Ben Weiss <benweiss@google.com>
Date: Thu Dec 10 16:20:02 2020

Add factory functions for DynamicNavHostFragment

Bug: 175222619
Test: updateApi and cAT
RelNote: Add factory functions for DynamicNavHostFragment
Change-Id: Icd51523a8f3cc3f93fffc1796c6a270bc28eaede

M navigation/navigation-dynamic-features-fragment/api/current.txt
M navigation/navigation-dynamic-features-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-dynamic-features-fragment/api/restricted_current.txt
M navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigatorDestinationBuilderTest.kt
M navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragmentTest.kt
M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java

https://android-review.googlesource.com/1523818

jb...@google.com <jb...@google.com> #3Sep 3, 2021 05:39PM

Marked as fixed.

I couldn't seem to find the create method in my codebase on the latest Navigation release 2.3.5. Has this change been merged into latest release?

https://androidx.tech/artifacts/navigation/navigation-dynamic-features-fragment/2.3.5-source/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.kt.html

ke...@northwesternmutual.com <ke...@northwesternmutual.com> #4Sep 20, 2021 04:53PM

This adds new APIs therefore will be available in Navigation 2.4.0-alpha01.

il...@google.com <il...@google.com> #5Sep 20, 2021 06:28PM

Re comment#4 - the regression in ordering in generated files is being tracked in b/200059831.

In the future, please always file regressions as new bugs with a sample project that reproduces your issue rather than commenting on issues already marked as fixed - that way we can properly track those fixes for the next release.

Issue 198493585

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Sep 1, 2021 11:21PM

jb...@google.com <jb...@google.com> #3Sep 3, 2021 05:39PM

ke...@northwesternmutual.com <ke...@northwesternmutual.com> #4Sep 20, 2021 04:53PM

il...@google.com <il...@google.com> #5Sep 20, 2021 06:28PM

Add comment

Issue metadata