Make parameters with defaults last in generated arguments [198493585]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Sep 1, 2021 10:38PM

In Navigation 2.4.0-alpha08 https://issuetracker.google.com/188855904 made generated directions classes make default parameters last to match Kotlin coding style. We should also do the same for generated arguments.

Comments

ap...@google.com <ap...@google.com> #2Sep 1, 2021 11:21PM

Please include a sample project that reproduces your issue.

jb...@google.com <jb...@google.com> #3Sep 3, 2021 05:39PM

Marked as fixed.

This should demonstrate the issue:

https://github.com/zackjp/safeargs-default-values-test

Run the unit test:

https://github.com/zackjp/safeargs-default-values-test/blob/master/app/src/test/java/com/zack/safeargsdefaultvaluestest/DefaultValuesInActionsTest.java

ke...@northwesternmutual.com <ke...@northwesternmutual.com> #4Sep 20, 2021 04:53PM

Maybe it is the same as the other issue I listed? Different use case but same root cause?

il...@google.com <il...@google.com> #5Sep 20, 2021 06:28PM

Switching to Kotlin Safe Args fixed the issue, so seems like the same issue, just on the Directions side (vs the other which is on the Args side).

Issue 198493585

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Sep 1, 2021 11:21PM

jb...@google.com <jb...@google.com> #3Sep 3, 2021 05:39PM

ke...@northwesternmutual.com <ke...@northwesternmutual.com> #4Sep 20, 2021 04:53PM

il...@google.com <il...@google.com> #5Sep 20, 2021 06:28PM

Add comment

Issue metadata