Fixed
Status Update
Comments
sc...@google.com <sc...@google.com>
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit b23be7f7903c4350f2846a71961ed517cded2f47
Author: Charcoal Chen <charcoalchen@google.com>
Date: Thu Sep 02 21:09:22 2021
Rename ExtensionMode#BEAUTY to FACE_RETOUCH
Relnote: "Renamed ExtensionMode#BEAUTY to FACE_RETOUCH to correctly present what is done by the extension mode."
Bug: 198515274
Test: ./gradlew camera:camera-extensions:build && ./gradlew camera:camera-extensions:connectedAndroidTest
Change-Id: I61f544ce058d1ee39722825fd95e7bb1e1ac6349
M camera/camera-extensions/src/androidTest/java/androidx/camera/extensions/util/ExtensionsTestUtil.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/ExtensionMode.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/ExtensionsInfo.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/AdvancedVendorExtender.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/BasicVendorExtender.java
M camera/integration-tests/extensionstestapp/src/androidTest/java/androidx/camera/integration/extensions/PreviewProcessorTimestampTest.java
M camera/integration-tests/extensionstestapp/src/main/java/androidx/camera/integration/extensions/CameraExtensionsActivity.java
https://android-review.googlesource.com/1817919
Branch: androidx-main
commit b23be7f7903c4350f2846a71961ed517cded2f47
Author: Charcoal Chen <charcoalchen@google.com>
Date: Thu Sep 02 21:09:22 2021
Rename ExtensionMode#BEAUTY to FACE_RETOUCH
Relnote: "Renamed ExtensionMode#BEAUTY to FACE_RETOUCH to correctly present what is done by the extension mode."
Bug: 198515274
Test: ./gradlew camera:camera-extensions:build && ./gradlew camera:camera-extensions:connectedAndroidTest
Change-Id: I61f544ce058d1ee39722825fd95e7bb1e1ac6349
M camera/camera-extensions/src/androidTest/java/androidx/camera/extensions/util/ExtensionsTestUtil.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/ExtensionMode.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/ExtensionsInfo.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/AdvancedVendorExtender.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/BasicVendorExtender.java
M camera/integration-tests/extensionstestapp/src/androidTest/java/androidx/camera/integration/extensions/PreviewProcessorTimestampTest.java
M camera/integration-tests/extensionstestapp/src/main/java/androidx/camera/integration/extensions/CameraExtensionsActivity.java
ch...@google.com <ch...@google.com> #4
"Beauty" term still exists on DAC in two places:
These effects include Portrait, HDR, Night, and Beauty.
The first set of capabilities available include Portrait, HDR, Night, and Beauty. These capabilities are available on supported devices.
BeautyImageCaptureExtender
BeautyPreviewExtender
For the Overview page, we can rename those words directly. For the Vendor extensions page, we can sync the Legacy Extensions API Removal
paragraph in
er...@google.com <er...@google.com>
gf...@google.com <gf...@google.com>
gf...@google.com <gf...@google.com> #7
Oh, created cl/394772017, it does not conflict with yours. So feel free to merge yours. Thank you
gf...@google.com <gf...@google.com> #8
cl/395565590 submitted. this could be closed now.
Description
This is a request to rename the CameraX Extension "Beauty" to "Face Retouch".