Nullable Navigation arguments are incorrectly marked as "required" and app crashes. [198689811]

Fixed

Bug

Status Update

No update yet.

Description

br...@gmail.com

created issue #1

Sep 3, 2021 01:11PM

Component used: Navigation Version used: 2.4.0-alpha08 Devices/Android versions reproduced on: All

It seems that the fix for https://issuetracker.google.com/issues/185527157 has introduced another bug. Nullable arguments with an @null default value are incorrectly treated as required, and cause the app to crash if they are not present in a deep link. You will get the following error:

java.lang.IllegalArgumentException: Deep link myurl.com/program/{id}?someArg={someArg} can't be used to open destination Destination(com.someapp.android:id/SomeFragment) label=SomeFragment class=com.someapp.android.features.SomeFragment.
    Following required arguments are missing: [someArg]

The Nav Graph defines the argument like this:

<argument
    android:name="someArg"
    app:argType="string"
    app:nullable="true"
    android:defaultValue="@null"/>

Comments

jb...@google.com <jb...@google.com> Sep 3, 2021 03:33PM

Assigned to sa...@google.com.

ap...@google.com <ap...@google.com> #2Sep 7, 2021 10:34PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

il...@google.com <il...@google.com> #3Sep 8, 2021 06:16PM

Marked as fixed.

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

sj...@gmail.com <sj...@gmail.com> #4Sep 17, 2021 10:46AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

il...@google.com <il...@google.com> #5Sep 20, 2021 12:00AM

Re comment#4 - please file a new bug with a sample project that reproduces your issue.

sj...@gmail.com <sj...@gmail.com> #6Sep 22, 2021 08:56AM

I'm sorry, I forgot to upgrade the Safe Args Gradle plugin as well. However when upgrading the plugin I now get another error.

Issue 198689811