Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit c7e2528a8cbd248e47f52ccd3b988b4cf7115520
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Sep 07 12:34:11 2021
Convert FragmentStrictMode to Kotlin
We now have a Kotlin dependency and this is a new API so we can go ahead
and convert it to Kotlin as well.
RelNote: "FragmentStrictMode is now in Kotlin"
Test: ./gradlew checkApi
Bug: 199183506
Change-Id: I117679edc3af067bb0ef901714ace02712c97a40
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentReuseViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetRetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetTargetFragmentRequestCodeUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetTargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/RetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetRetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetTargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetUserVisibleHintViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/TargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/Violation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/WrongFragmentContainerViolation.kt
https://android-review.googlesource.com/1817362
Branch: androidx-main
commit c7e2528a8cbd248e47f52ccd3b988b4cf7115520
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Sep 07 12:34:11 2021
Convert FragmentStrictMode to Kotlin
We now have a Kotlin dependency and this is a new API so we can go ahead
and convert it to Kotlin as well.
RelNote: "FragmentStrictMode is now in Kotlin"
Test: ./gradlew checkApi
Bug: 199183506
Change-Id: I117679edc3af067bb0ef901714ace02712c97a40
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentReuseViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetRetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetTargetFragmentRequestCodeUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetTargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/RetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetRetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetTargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetUserVisibleHintViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/TargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/Violation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/WrongFragmentContainerViolation.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 80b3df8ddb14a4a706a853bfefc361045d9f1168
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 08 15:11:47 2021
Use RuntimeException constructor with message
Instead of overriding getMessage for all for the violations, we should
use the constructor of RuntimeException that takes a message instead.
RelNote: N/A
Test: ./gradlew checkApi
Bug: 199183506
Change-Id: I50b52af7e20b0fed466520172c3438e3bc2a8b2f
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentReuseViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetRetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetTargetFragmentRequestCodeUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetTargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/RetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetRetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetTargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetUserVisibleHintViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/TargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/Violation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/WrongFragmentContainerViolation.kt
https://android-review.googlesource.com/1822598
Branch: androidx-main
commit 80b3df8ddb14a4a706a853bfefc361045d9f1168
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 08 15:11:47 2021
Use RuntimeException constructor with message
Instead of overriding getMessage for all for the violations, we should
use the constructor of RuntimeException that takes a message instead.
RelNote: N/A
Test: ./gradlew checkApi
Bug: 199183506
Change-Id: I50b52af7e20b0fed466520172c3438e3bc2a8b2f
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentReuseViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetRetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetTargetFragmentRequestCodeUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetTargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/RetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetRetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetTargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetUserVisibleHintViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/TargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/Violation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/WrongFragmentContainerViolation.kt
jb...@google.com <jb...@google.com> #4
This has been added internally and will be available in the Fragment 1.4.0-alpha09
release.
Description
We now have as dependency on the kotlin standard library and the FragmentStrictMode changes were new in this alpha so we can make them into Kotlin without breaking changes.