Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021
[GH] [FragmentStrictMode] Detect <fragment> tag usage
## Proposed Changes
- Detect `<fragment>` tag usage inside XML layouts
## Testing
Test: See `FragmentStrictModeTest#detectFragmentTagUsage`
## Issues Fixed
Fixes: 153738235
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/141 .
Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java
https://android-review.googlesource.com/1649748
Branch: androidx-main
commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021
[GH] [FragmentStrictMode] Detect <fragment> tag usage
## Proposed Changes
- Detect `<fragment>` tag usage inside XML layouts
## Testing
Test: See `FragmentStrictModeTest#detectFragmentTagUsage`
## Issues Fixed
Fixes: 153738235
This is an imported pull request from
Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 80b3df8ddb14a4a706a853bfefc361045d9f1168
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 08 15:11:47 2021
Use RuntimeException constructor with message
Instead of overriding getMessage for all for the violations, we should
use the constructor of RuntimeException that takes a message instead.
RelNote: N/A
Test: ./gradlew checkApi
Bug: 199183506
Change-Id: I50b52af7e20b0fed466520172c3438e3bc2a8b2f
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentReuseViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetRetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetTargetFragmentRequestCodeUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetTargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/RetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetRetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetTargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetUserVisibleHintViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/TargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/Violation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/WrongFragmentContainerViolation.kt
https://android-review.googlesource.com/1822598
Branch: androidx-main
commit 80b3df8ddb14a4a706a853bfefc361045d9f1168
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 08 15:11:47 2021
Use RuntimeException constructor with message
Instead of overriding getMessage for all for the violations, we should
use the constructor of RuntimeException that takes a message instead.
RelNote: N/A
Test: ./gradlew checkApi
Bug: 199183506
Change-Id: I50b52af7e20b0fed466520172c3438e3bc2a8b2f
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentReuseViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetRetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetTargetFragmentRequestCodeUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/GetTargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/RetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetRetainInstanceUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetTargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/SetUserVisibleHintViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/TargetFragmentUsageViolation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/Violation.kt
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/WrongFragmentContainerViolation.kt
jb...@google.com <jb...@google.com> #4
This has been added internally and will be available in the Fragment 1.4.0-alpha09
release.
Description
We now have as dependency on the kotlin standard library and the FragmentStrictMode changes were new in this alpha so we can make them into Kotlin without breaking changes.