NotificationCompat still doesn't support CallStyle [199294989]

Fixed

Feature Request

Status Update

No update yet.

Description

el...@gmail.com

created issue #1

Sep 9, 2021 08:11AM

Component used: androidx.core:core-ktx Version used: 1.7.0-alpha02 Devices/Android versions reproduced on: N/A

Hi,

Notification.CallStyle API has been announced for a while now, but there is still no mention of the CallStyle in the NotificationCompat API. Do you plan on adding it?

Best regards,

Comments

al...@google.com <al...@google.com> Sep 9, 2021 02:14PM

Reassigned to ju...@google.com.

ju...@google.com <ju...@google.com> Sep 9, 2021 02:19PM

Reassigned to je...@google.com.

4b...@gmail.com <4b...@gmail.com> #2Oct 8, 2021 03:12PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

el...@gmail.com <el...@gmail.com> #3Oct 13, 2021 03:06PM

Hi,

Could you at least tell us if you will add the CallStyle to the NotificationCompat API?

Best regards,

je...@google.com <je...@google.com> #4Oct 13, 2021 03:54PM

Yes. Our goal is to provide an implementation that uses CallStyle on API 31+ and uses the new fields to produce a usable call notification, based on the device's standard template, on older versions of Android.

el...@gmail.com <el...@gmail.com> #5Oct 14, 2021 07:29AM

Thanks for the answer. Do you have an estimated ETA?

el...@gmail.com <el...@gmail.com> #6Nov 9, 2021 10:41AM

Any update on this please?

el...@gmail.com <el...@gmail.com> #7Nov 18, 2021 08:04AM

Could you please give us an ETA?

el...@gmail.com <el...@gmail.com> #8Dec 1, 2021 02:19PM

Hello again,

It's been a while now that Android 12 has been released, and it would be great to have an estimated time of arrival for this feature in appcompat package so we can plan our developments & releases as app developers.

Thanks in advance.

be...@gmail.com <be...@gmail.com> #9Dec 20, 2021 10:01AM

Hi @google,
Any update on this please?

gr...@gmail.com <gr...@gmail.com> #10Jan 16, 2022 10:23AM

Is this planned for androidx.core:core:1.8.0 ?

el...@gmail.com <el...@gmail.com> #11Feb 23, 2022 10:25AM

Is someone there? -_-

el...@gmail.com <el...@gmail.com> #12Mar 25, 2022 03:50PM

Google has left the bugtracker

ju...@google.com <ju...@google.com> Apr 5, 2022 07:17PM

Reassigned to an...@google.com.

el...@gmail.com <el...@gmail.com> #13May 9, 2022 12:30PM

Any news?

el...@gmail.com <el...@gmail.com> #14Jun 1, 2022 12:06PM

Monthly ping...

el...@gmail.com <el...@gmail.com> #15Jul 4, 2022 07:28AM

Seriously guys it's been 10 months...

jd...@xooloo.com <jd...@xooloo.com> #16Jul 19, 2022 09:13AM

Hello guys, this Style is now required on Android 13 to get Notification Permission exemption for VoIP Apps.

If you want dev to adopt Android 13 API, you should really consider including it in AndroidX.

Having such important feature ignored for months, is a strong signal that adopting Android 13 API should be delayed for any serious developer.

ag...@snappler.com <ag...@snappler.com> #17Jul 19, 2022 03:16PM

Comment has been deleted.

Message last modified on Jul 19, 2022 03:16PM

ar...@google.com <ar...@google.com> Aug 11, 2022 03:46PM

Accepted by ar...@google.com.

ko...@gmail.com <ko...@gmail.com> #18Aug 23, 2022 06:24AM

Ping, guys.

el...@gmail.com <el...@gmail.com> #19Sep 7, 2022 11:00AM

Monthly ping

kw...@visualtouchpos.com <kw...@visualtouchpos.com> #20Sep 14, 2022 05:00PM

ping please

ar...@gmail.com <ar...@gmail.com> #21Sep 30, 2022 03:57PM

What do we want? CallStyle in NotificationCompat!!! When do we want it? Months ago!

Message last modified on Sep 30, 2022 03:57PM

ar...@gmail.com <ar...@gmail.com> #22Oct 27, 2022 01:32PM

Please update on ETA

ap...@google.com <ap...@google.com> #23Dec 2, 2022 01:55PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5916349f37585425a855d0b13259009d1843d28c
Author: Alexander Roederer <aroederer@google.com>
Date: Wed Aug 10 14:44:51 2022

Adds CallStyle to NotificationCompat

Adds CallStyle to NotificationCompat. Adds support for use of
Notification.CallStyle in API version 31 and higher, and creates an
unstyled notification that mimics the look of CallStyle in versions
lower than 31. Also adds testing to cover these cases.

Test: Added unit test coverage for all new class uses
Bug: 199294989
Change-Id: Id9a5321ab9172a004215c85aa2e6d7165a01e074
Relnote: Adds Callstyle to NotificationCompat

M core/core/api/current.txt
M core/core/api/public_plus_experimental_current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/app/NotificationCompatTest.java
M core/core/src/main/java/androidx/core/app/NotificationCompat.java
A core/core/src/main/res/drawable/ic_call_answer.xml
A core/core/src/main/res/drawable/ic_call_answer_low.xml
A core/core/src/main/res/drawable/ic_call_answer_video.xml
A core/core/src/main/res/drawable/ic_call_answer_video_low.xml
A core/core/src/main/res/drawable/ic_call_decline.xml
A core/core/src/main/res/drawable/ic_call_decline_low.xml
M core/core/src/main/res/values/colors.xml
M core/core/src/main/res/values/strings.xml

https://android-review.googlesource.com/2269806

ar...@google.com <ar...@google.com> #24Dec 2, 2022 02:02PM

Marked as fixed.

CallStyle is now available in NotificationCompat. Please note associated doc comments regarding the use of this style, namely that CallStyle Notifications need to be associated with a foreground service and for proper ranking on older versions, we encourage marking the Notification as colorized, using Builder#setColorized.

na...@google.com <na...@google.com> #25Jan 11, 2023 08:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.core:core:1.10.0-alpha01