Status Update
Comments
al...@google.com <al...@google.com>
ju...@google.com <ju...@google.com>
4b...@gmail.com <4b...@gmail.com> #2
The issue is reproducible with core-ktx 1.2.0 and 1.3.0-rc01.
el...@gmail.com <el...@gmail.com> #3
The Typeface.weight is not a weight of the underlying font file. It is a display style. On older APIs, the display style is adjusted if the Typeface is created from single font. However, after moving to CustomFallbackBuilder, that adjustment is removed since it can crate Typeface from multiple style font files.
Looks like it is good to set display style by ResourcesCompat.getFont for backward compatibility.
je...@google.com <je...@google.com> #4
Hi Nona,
Can you please schedule a release after you merge the fix?
el...@gmail.com <el...@gmail.com> #5
Branch: androidx-master-dev
commit 3d6aa2e9b3243dcc4de1f54bd8d40339bd69cb05
Author: Seigo Nonaka <nona@google.com>
Date: Wed May 27 17:38:05 2020
Adjust the Typeface display style with the style of given font
This behavir is implicitly done by Typeface.Builder and
Typeface.createXXX function but not to be done by
Typeface.CustomFallbackBuilder since it is designed to be working
with multiple font files which has different style.
Looks like the style argument is ignored on older API implementation.
Bug: 156853883
Bug: 152023266
Test: ResourcesCompatTest#testGetFont_adjustDisplayStyle passes on 29
Test: ./gradlew core:core:connectedAndroidTest on API 29, 28, 23
Change-Id: I3a377c339a7aed50973cf11df86ddf0069f4ec25
A core/core/src/androidTest/assets/fonts/thin_italic.ttf
A core/core/src/androidTest/assets/fonts/thin_italic.ttx
M core/core/src/androidTest/java/androidx/core/content/res/ResourcesCompatTest.java
A core/core/src/androidTest/res/font/thin_italic.ttf
M core/core/src/main/java/androidx/core/graphics/TypefaceCompatApi29Impl.java
el...@gmail.com <el...@gmail.com> #7
Any way I can tell what version this will land in?
be...@gmail.com <be...@gmail.com> #9
Great—works as expected, thanks!
gr...@gmail.com <gr...@gmail.com> #10
el...@gmail.com <el...@gmail.com> #11
Is someone there? -_-
el...@gmail.com <el...@gmail.com> #12
Google has left the bugtracker
ju...@google.com <ju...@google.com>
el...@gmail.com <el...@gmail.com> #13
Any news?
el...@gmail.com <el...@gmail.com> #14
Monthly ping...
el...@gmail.com <el...@gmail.com> #15
jd...@xooloo.com <jd...@xooloo.com> #16
Hello guys, this Style is now required on Android 13 to get Notification Permission exemption for VoIP Apps.
If you want dev to adopt Android 13 API, you should really consider including it in AndroidX.
Having such important feature ignored for months, is a strong signal that adopting Android 13 API should be delayed for any serious developer.
ag...@snappler.com <ag...@snappler.com> #17
ar...@google.com <ar...@google.com>
ko...@gmail.com <ko...@gmail.com> #18
el...@gmail.com <el...@gmail.com> #19
kw...@visualtouchpos.com <kw...@visualtouchpos.com> #20
ar...@gmail.com <ar...@gmail.com> #21
ar...@gmail.com <ar...@gmail.com> #22
ap...@google.com <ap...@google.com> #23
Branch: androidx-main
commit 5916349f37585425a855d0b13259009d1843d28c
Author: Alexander Roederer <aroederer@google.com>
Date: Wed Aug 10 14:44:51 2022
Adds CallStyle to NotificationCompat
Adds CallStyle to NotificationCompat. Adds support for use of
Notification.CallStyle in API version 31 and higher, and creates an
unstyled notification that mimics the look of CallStyle in versions
lower than 31. Also adds testing to cover these cases.
Test: Added unit test coverage for all new class uses
Bug: 199294989
Change-Id: Id9a5321ab9172a004215c85aa2e6d7165a01e074
Relnote: Adds Callstyle to NotificationCompat
M core/core/api/current.txt
M core/core/api/public_plus_experimental_current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/app/NotificationCompatTest.java
M core/core/src/main/java/androidx/core/app/NotificationCompat.java
A core/core/src/main/res/drawable/ic_call_answer.xml
A core/core/src/main/res/drawable/ic_call_answer_low.xml
A core/core/src/main/res/drawable/ic_call_answer_video.xml
A core/core/src/main/res/drawable/ic_call_answer_video_low.xml
A core/core/src/main/res/drawable/ic_call_decline.xml
A core/core/src/main/res/drawable/ic_call_decline_low.xml
M core/core/src/main/res/values/colors.xml
M core/core/src/main/res/values/strings.xml
ar...@google.com <ar...@google.com> #24
CallStyle is now available in NotificationCompat. Please note associated doc comments regarding the use of this style, namely that CallStyle Notifications need to be associated with a foreground service and for proper ranking on older versions, we encourage marking the Notification as colorized, using Builder#setColorized.
na...@google.com <na...@google.com> #25
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.core:core:1.10.0-alpha01
Description
Component used: androidx.core:core-ktx Version used: 1.7.0-alpha02 Devices/Android versions reproduced on: N/A
Hi,
Notification.CallStyle API has been announced for a while now, but there is still no mention of the CallStyle in the NotificationCompat API. Do you plan on adding it?
Best regards,