Fixed
Status Update
Comments
ma...@google.com <ma...@google.com>
nj...@google.com <nj...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
lc...@gmail.com <lc...@gmail.com> #3
lc...@gmail.com <lc...@gmail.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ya...@google.com <ya...@google.com>
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 41a75f709cccf2d76c5215db41b2fe9d21ea9dd3
Author: Yuichi Araki <yaraki@google.com>
Date: Mon Jan 17 14:19:12 2022
Implement repeat for AnimatedImageVector
Replaces the internal implementation of AnimatedImageVector. Instead of converting all the animator
keyframes into a keyframes AnimationSpec, it now uses an internal AnimationSpec that combines
multiple FiniteAnimationSpec. Similarly, AnimationSpecs are reversed by wrapping it with a custom
AnimationSpec. This allows us to repeat such AnimationSpecs separately.
Relnote: "AnimatedImageVector now supports repeatCount and repeatMode"
Test: ./gradlew :compose:animation:animation-graphics:connectedCheck
Bug: 199304067
Change-Id: Ia3e75fe74f9552c2a1ce4a0995d781009b7a5257
A compose/animation/animation-graphics/src/androidAndroidTest/kotlin/androidx/compose/animation/graphics/vector/AnimatorAnimationSpecsTest.kt
M compose/animation/animation-graphics/api/restricted_current.txt
M compose/animation/animation-graphics/src/commonMain/kotlin/androidx/compose/animation/graphics/vector/Animator.kt
M compose/animation/animation-graphics/src/androidAndroidTest/kotlin/androidx/compose/animation/graphics/vector/AnimatorTest.kt
M compose/animation/animation-graphics/api/current.txt
M compose/animation/animation-graphics/api/public_plus_experimental_current.txt
A compose/animation/animation-graphics/src/commonMain/kotlin/androidx/compose/animation/graphics/vector/AnimatorAnimationSpecs.kt
https://android-review.googlesource.com/1958567
Branch: androidx-main
commit 41a75f709cccf2d76c5215db41b2fe9d21ea9dd3
Author: Yuichi Araki <yaraki@google.com>
Date: Mon Jan 17 14:19:12 2022
Implement repeat for AnimatedImageVector
Replaces the internal implementation of AnimatedImageVector. Instead of converting all the animator
keyframes into a keyframes AnimationSpec, it now uses an internal AnimationSpec that combines
multiple FiniteAnimationSpec. Similarly, AnimationSpecs are reversed by wrapping it with a custom
AnimationSpec. This allows us to repeat such AnimationSpecs separately.
Relnote: "AnimatedImageVector now supports repeatCount and repeatMode"
Test: ./gradlew :compose:animation:animation-graphics:connectedCheck
Bug: 199304067
Change-Id: Ia3e75fe74f9552c2a1ce4a0995d781009b7a5257
A compose/animation/animation-graphics/src/androidAndroidTest/kotlin/androidx/compose/animation/graphics/vector/AnimatorAnimationSpecsTest.kt
M compose/animation/animation-graphics/api/restricted_current.txt
M compose/animation/animation-graphics/src/commonMain/kotlin/androidx/compose/animation/graphics/vector/Animator.kt
M compose/animation/animation-graphics/src/androidAndroidTest/kotlin/androidx/compose/animation/graphics/vector/AnimatorTest.kt
M compose/animation/animation-graphics/api/current.txt
M compose/animation/animation-graphics/api/public_plus_experimental_current.txt
A compose/animation/animation-graphics/src/commonMain/kotlin/androidx/compose/animation/graphics/vector/AnimatorAnimationSpecs.kt
lc...@gmail.com <lc...@gmail.com> #6
Am i missing something? I tried compose animation graphics version 1.2.0-beta01. However my avd (in #1) is still not repeating/looping infinitely. Am i doing anything wrong?
val image = AnimatedImageVector.animatedVectorResource(id)
val atEnd = remember { mutableStateOf(false) }
SideEffect {
atEnd.value = true
}
Image(
painter = rememberAnimatedVectorPainter(image, atEnd.value),
modifier = Modifier
.wrapContentSize(align = Alignment.Center),
contentDescription = null
)
lc...@gmail.com <lc...@gmail.com> #7
It seems that compose animatedVectorImage still does not support infinitely repeating animations. I may be wrong but from this piece of code in the androidx.compose.animation.graphics.vector.Animator
class. This function seems to only make the animation repeatable if the repeatCount is > 0.
internal class Timestamp<T>(
val timeMillis: Int,
val durationMillis: Int,
val repeatCount: Int,
val repeatMode: RepeatMode,
val holder: PropertyValuesHolder<T>
) {
fun asAnimationSpec(): FiniteAnimationSpec<T> {
@Suppress("UNCHECKED_CAST")
val spec = when (holder) {
is PropertyValuesHolderFloat -> holder.asKeyframeSpec(durationMillis)
is PropertyValuesHolderColor -> holder.asKeyframeSpec(durationMillis)
else -> throw RuntimeException("Unexpected value type: $holder")
} as KeyframesSpec<T>
return if (repeatCount > 0) {
repeatable(
iterations = repeatCount + 1,
animation = spec,
repeatMode = repeatMode
)
} else {
spec
}
}
}
However for xml avd, repeatcount is infinitely repeatable if the repeatCount is -1 which causes the animation to not repeat at all.
<!-- Defines how many times the animation should repeat. The default value is 0. -->
<attr name="repeatCount" format="integer">
<enum name="infinite" value="-1" />
</attr>
lc...@gmail.com <lc...@gmail.com> #8
created another issue here
an...@sigma.software <an...@sigma.software> #9
This is not fixed. I have a complex animation set with multiple sequential object animators, and it's impossible to loop the animation.
Description
Component used: androidx.compose.animation:animation-graphics
Version used: 1.1.0-alpha03
Devices/Android versions reproduced on: all devices and android versions
If this is a bug in the library, we would appreciate if you could attach:
Don't think this is a bug, more like a feature gap?
Code snippet of my avd composable
Avd repeating animations are not repeating, and looks like the current painter api also does not support this use case. Does not seem to respect the avd's
android:repeatCount="-1"
attribute. Avd used to replicate "issue" attached.