IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit 22fe26bc907af50d557254d406eb38469a7bb81b
Author: Rahul Ravikumar <rahulrav@google.com>
Date:   Fri Apr 16 11:15:58 2021

    Add unbundled perfetto support.
   
    With this change, we are much closer in bringing Macrobenchmarks to API 21.
   
    The things we need to tackle after this CL lands are:
   
    * Follow up on this CL (https://android-review.googlesource.com/c/platform/external/perfetto/+/1680145).
      The binaries checked in, include this change but currently its failing presubmits because of a compiler warning.
      Something primiano@ is currently looking into.
    * Expand trace_processor_shells ABI support to include arm, and x86_64.
      Remove the explicit checks for API Q.
    * Remove the use of @RequiresApi(...) in MacrobenchmarkRule, and explicit checks for API Q.
    * verifyTraceEnabled(...) does seem to cause issues on lower versions of the platform. Something we need to investigate further.
      This does not happen consistently though.
    * Fix our perfetto trace configs. There are options that are unsupported on older versions of the platform.
    * M, and N dont support several ART compilation modes. No op on them.
   
    Test: PerfettoCaptureTest is now parameterized
    Bug: b/183129298
   
    Change-Id: I888fa15e02acc4f99fbf548722a11a9953988357

M       benchmark/macro/build.gradle
M       benchmark/macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoCaptureTest.kt
M       benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoCapture.kt
M       benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoCaptureWrapper.kt
M       benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoHelper.kt

https://android-review.googlesource.com/1675367

Project: platform/prebuilts/androidx/traceprocessor
Branch: androidx-main

commit 9f143a6b876ef5b2be841ed2ce1be138e325bf51
Author: Rahul Ravikumar <rahulrav@google.com>
Date:   Wed Mar 31 14:49:19 2021

    Add stripped perfetto and trace_processor_shell binaries.
   
    * These binaries are built from source (https://github.com/google/perfetto)
    * Build instructions are https://perfetto.dev/docs/contributing/build-instructions
    * The config looks something like:
   
    ```
    target_os = "android"
    target_cpu = "arm|arm64|arm_x86_x86"
    is_debug = false
    monolithic_binaries = true
    ```
   
    * After building, we stripped the binaries using ndk `22.1.7171670` using `/path/to/sdk/ndk/22.1.7171670/toolchains/llvm/prebuilt/linux-x86_64/<variant>-linux-android/bin/strip`
   
    Test: ./gradlew :benchmark:integration-tests:macrobenchmark:connectedDebugAndroidTest
    Bug: b/183129298
    Change-Id: I052b6caf214a3d0dfd101302040f6ae43bc42b22

M       README.md
A       perfetto/perfetto_aarch64
A       perfetto/perfetto_arm
A       perfetto/perfetto_x86_64
M       trace_processor_shell/trace_processor_shell_aarch64
A       trace_processor_shell/trace_processor_shell_arm
A       trace_processor_shell/trace_processor_shell_x86_64
A       traced/traced_aarch64
A       traced/traced_arm
A       traced/traced_x86_64
A       traced_probes/traced_probes_aarch64
A       traced_probes/traced_probes_arm
A       traced_probes/traced_probes_x86_64

https://android-review.googlesource.com/1660781

Project: platform/frameworks/support
Branch: androidx-main

commit ce3df5c24d36ac56873d13bb27a084e54e420dd7
Author: Rahul Ravikumar <rahulrav@google.com>
Date:   Tue Apr 20 12:16:02 2021

    Expand ABI support for `perfetto_trace_processor`.
   
    Test: ./gradlew :benchmark:benchmark-macro:connectedCheck
    Bug: Bug: b/183129298
    Change-Id: Ic7c5579b497890b2eab8f202b41d2a2c2560c1fb

M       benchmark/macro/src/androidTest/java/androidx/benchmark/macro/StartupTimingMetricTest.kt
M       benchmark/macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessorTest.kt
M       benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessor.kt

https://android-review.googlesource.com/1681590