Remove TextFieldColorsWithIcons interface and move its methods to base interface. [199377790]

Assigned

Bug

Status Update

No update yet.

Description

os...@google.com

created issue #1

Sep 9, 2021 12:01PM

Currently in aosp/1810198 suggests interface with new methods instead of adding this methods to TextFieldColors interface (because of b/198571248). Move these methods to TextFieldColors and deprecate

fun leadingIconColor(enabled: Boolean, isError: Boolean): State<Color> 

fun trailingIconColor(enabled: Boolean, isError: Boolean): State<Color>

when it'll be possible

Comments

so...@google.com <so...@google.com> #2Jan 25, 2022 04:22PM

Lines for reference in ModalBottomSheet.android.kt causing this behavior:

val newTarget = when (sheetState.anchoredDraggableState.targetValue) {
  Hidden -> Hidden
  PartiallyExpanded, Expanded -> {
    val hasPartiallyExpandedState = newAnchors
        .hasAnchorFor(PartiallyExpanded)
    val newTarget = if (hasPartiallyExpandedState) PartiallyExpanded
    else if (newAnchors.hasAnchorFor(Expanded)) Expanded else Hidden
    newTarget
  }
}

so...@google.com <so...@google.com> #3Feb 10, 2022 07:01PM

Reassigned to ma...@google.com.

My proposed solution would be:

val targetValue = sheetState.anchoredDraggableState.targetValue
val newTarget = when (targetValue) {
  Hidden -> Hidden
  PartiallyExpanded, Expanded -> {
    when {
      newAnchors.hasAnchorFor(targetValue)) -> targetValue
      newAnchors.hasAnchorFor(PartiallyExpanded)) -> PartiallyExpanded
      newAnchors.hasAnchorFor(Expanded)) -> Expanded 
      else -> Hidden
    }
  }
}

ma...@google.com <ma...@google.com> Mar 3, 2022 07:40PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #4Mar 8, 2022 12:59PM

Project: chromium/src
Branch: main

commit 0fe5e3c558992a1c0b5b2aef2594049862b1c703
Author: Zach Katz <katzz@google.com>
Date: Fri May 03 23:02:15 2024

[ASH] Add fieldtrial_testing_config

Bug: 324934884
Change-Id: Ib9d0ade90999a67cd74d1b94e6ab43087b5e1ead
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5516358
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Zach Katz <katzz@google.com>
Cr-Commit-Position: refs/heads/main@{#1296421}

M testing/variations/fieldtrial_testing_config.json

https://chromium-review.googlesource.com/5516358

co...@google.com <co...@google.com> #5Jun 6, 2022 03:39PM

Marked as fixed, reassigned to ma...@google.com.

any update on this? 😅

co...@google.com <co...@google.com> #6Jun 7, 2022 01:18PM

Status: Assigned (reopened)

any updates?

ap...@google.com <ap...@google.com> #7Jun 21, 2023 06:28PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jose Figueroa <serniebanders@google.com>
Link: https://android-review.googlesource.com/3341638

[M3][BottomSheets] Update Expanded target to remain expanded on resize.

Expand for full commit details

[M3][BottomSheets] Update Expanded target to remain expanded on resize. 
 
Expanded anchor is always defined. 
 
Bug: 324934884 
Test: Add Expanded check to anchor testing 
RelNote: "Expanded bottom sheet remains expanded on size change." 
Change-Id: I2870ba38420d18b02676e6f280ef96dddc6a3a8a

Files:

M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt

Hash: 0a8673ffe397d5cfe341fa60a281212388c3f1e0
Date: Fri Nov 08 16:59:04 2024