Remove TextFieldColorsWithIcons interface and move its methods to base interface. [199377790]

Assigned

Bug

Status Update

No update yet.

Description

os...@google.com

created issue #1

Sep 9, 2021 12:01PM

Currently in aosp/1810198 suggests interface with new methods instead of adding this methods to TextFieldColors interface (because of b/198571248). Move these methods to TextFieldColors and deprecate

fun leadingIconColor(enabled: Boolean, isError: Boolean): State<Color> 

fun trailingIconColor(enabled: Boolean, isError: Boolean): State<Color>

when it'll be possible

Comments

so...@google.com <so...@google.com> #2Jan 25, 2022 04:22PM

test

so...@google.com <so...@google.com> #3Feb 10, 2022 07:01PM

Reassigned to ma...@google.com.

bulk comment, fyi: we have added icebox to all the tickets because it was suggested by blintz in order to prevent auto-close tickets. we want to keep our Compose tickets to remain opened.

see

b/123001228#comment6

ma...@google.com <ma...@google.com> Mar 3, 2022 07:40PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #4Mar 8, 2022 12:59PM

(bulk comment) Hi,

Can you please check if this task can be finished before June, and if not remove `Jetpack Compose Major Release (May 2020)` hotlist?

(apologies if this is a double comment)

Thank you

co...@google.com <co...@google.com> #5Jun 6, 2022 03:39PM

Marked as fixed, reassigned to ma...@google.com.

(bulk comment)
Please ignore last comment related to the June release. It was caused by a mistake in the query I used. Thank you.

co...@google.com <co...@google.com> #6Jun 7, 2022 01:18PM

Status: Assigned (reopened)

further postponing to category 3, since it doesn't look like we can accomplish this one. If time allows one of us will pick it up during category 2.

ap...@google.com <ap...@google.com> #7Jun 21, 2023 06:28PM

out of curiousity… if this isnt immediately planned, have you considered changing he default colors at all? a couple things i noticed:

(1) i could see the choice of purple + blue clashing with a number of existing apps, and maybe there are some better defaults that could be used to at least make the colors stand out less.

(2) the defaults don’t support dark mode very well. in our app, the dark purple handles on top of a primary dark mode background has only a 2.14:1 color contrast ratio (whereas in light mode the contrast is 8.98:1)