Remove TextFieldColorsWithIcons interface and move its methods to base interface. [199377790]

Assigned

Bug

Status Update

No update yet.

Description

os...@google.com

created issue #1

Sep 9, 2021 12:01PM

Currently in aosp/1810198 suggests interface with new methods instead of adding this methods to TextFieldColors interface (because of b/198571248). Move these methods to TextFieldColors and deprecate

fun leadingIconColor(enabled: Boolean, isError: Boolean): State<Color> 

fun trailingIconColor(enabled: Boolean, isError: Boolean): State<Color>

when it'll be possible

Comments

so...@google.com <so...@google.com> #2Jan 25, 2022 04:22PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020

IconButton / IconToggleButton API scrub

Test: ./gradlew updateApi
Bug:

b/161809385

Bug:

b/161807956

Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt

https://android-review.googlesource.com/1394868

so...@google.com <so...@google.com> #3Feb 10, 2022 07:01PM

Reassigned to ma...@google.com.

IIUC this could be done already. Even if the DropdownMenuDecorationBox was changed (since it's experimental API), keeping the shape of leadingIconColor as in TextFieldColorsWithIcons interface is useful

ma...@google.com <ma...@google.com> Mar 3, 2022 07:40PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #4Mar 8, 2022 12:59PM

Project: platform/frameworks/support
Branch: androidx-main

commit bc04e07467504a83aee772a5bb0d6216f11cc353
Author: Max Ying <maxying@google.com>
Date: Fri Feb 25 14:51:06 2022

Update M3 TextFieldColors interface.

TextFieldColorsWithIcons has been removed and its methods
have been incorporated into the parent interface.

Bug:

b/199377790

Test: n/a
Relnote: "Added support for Material 3 text fields."
Change-Id: I795cc83e59b56200517e2d5b5dfbbd48cf51aeda

M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TextFieldDefaults.kt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/api/current.txt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TextFieldImpl.kt
M compose/material3/material3/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/1999634

co...@google.com <co...@google.com> #5Jun 6, 2022 03:39PM

Marked as fixed, reassigned to ma...@google.com.

Marking as closed based on the commit message in aosp/1999634, please re-open if this is incorrect.

co...@google.com <co...@google.com> #6Jun 7, 2022 01:18PM

Status: Assigned (reopened)

Reopening the bug and moving to M5 hotlist because the cl above only made the change in material3.

Max, what's the plan for the the material2 text fields?

ap...@google.com <ap...@google.com> #7Jun 21, 2023 06:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit 15875941ac771415152c30e09a85394e0956304b
Author: Max Alfonso-Ying <maxying@google.com>
Date: Wed Jun 14 15:28:31 2023

Deprecate TextFieldColorsWithIcons

Its methods have been moved to TextFieldColors. The overload
of leading and trailing icon color without an interactionSource
parameter has been deprecated as well.

Bug:

b/199377790

Test: n/a
Relnote: "TextFieldColorsWithIcons in Material 2 has been deprecated
in favor of TextFieldColors. When overriding `leadingIconColor` or
`trailingIconColor`, also override the overload with `interactionSource`."
Change-Id: Id57eda2be81aa23263a9c9a83e89789934acf169

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidMain/kotlin/androidx/compose/material/ExposedDropdownMenu.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/2626351