Remove TextFieldColorsWithIcons interface and move its methods to base interface. [199377790]

Assigned

Bug

Status Update

No update yet.

Description

os...@google.com

created issue #1

Sep 9, 2021 12:01PM

Currently in aosp/1810198 suggests interface with new methods instead of adding this methods to TextFieldColors interface (because of b/198571248). Move these methods to TextFieldColors and deprecate

fun leadingIconColor(enabled: Boolean, isError: Boolean): State<Color> 

fun trailingIconColor(enabled: Boolean, isError: Boolean): State<Color>

when it'll be possible

Comments

so...@google.com <so...@google.com> #2Jan 25, 2022 04:22PM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

so...@google.com <so...@google.com> #3Feb 10, 2022 07:01PM

Reassigned to ma...@google.com.

Thanks for the report!

ma...@google.com <ma...@google.com> Mar 3, 2022 07:40PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #4Mar 8, 2022 12:59PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

co...@google.com <co...@google.com> #5Jun 6, 2022 03:39PM

Marked as fixed, reassigned to ma...@google.com.

deleted

co...@google.com <co...@google.com> #6Jun 7, 2022 01:18PM

Status: Assigned (reopened)

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

ap...@google.com <ap...@google.com> #7Jun 21, 2023 06:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit 15875941ac771415152c30e09a85394e0956304b
Author: Max Alfonso-Ying <maxying@google.com>
Date: Wed Jun 14 15:28:31 2023

Deprecate TextFieldColorsWithIcons

Its methods have been moved to TextFieldColors. The overload
of leading and trailing icon color without an interactionSource
parameter has been deprecated as well.

Bug:

b/199377790

Test: n/a
Relnote: "TextFieldColorsWithIcons in Material 2 has been deprecated
in favor of TextFieldColors. When overriding `leadingIconColor` or
`trailingIconColor`, also override the overload with `interactionSource`."
Change-Id: Id57eda2be81aa23263a9c9a83e89789934acf169

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidMain/kotlin/androidx/compose/material/ExposedDropdownMenu.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/2626351