Version used: 1.7.0-alpha02. Also affects Activity 1.4.0-alpha01 and up.
When using the addMenuProvider methods that take a Lifecycle, calling removeMenuProvider doesn't actually remove the underlying LifecycleObserver that MenuHostHelper adds.
This has a couple of implications:
If removeMenuProvider is called when the Lifecycle is below the given state, removeMenuProvider doesn't remove the MenuProvider and when the Lifecycle reaches the given state, it still gets added
If removeMenuProvider is called when the Lifecycle is above the given state, removeMenuProviderdoes remove the MenuProvider, but if the Lifecycle goes down and then back up again, it gets re-added.
ActivityResultRegistry handles these cases (register with a LifecycleOwner, then calling unregister) by holding onto the LifecycleOwner + LifecycleObserver instances. Something similar should probably be done here using the original MenuProvider as the key.
Description
Component used: Core
Version used: 1.7.0-alpha02. Also affects Activity
1.4.0-alpha01and up.When using the
addMenuProvidermethods that take aLifecycle, callingremoveMenuProviderdoesn't actually remove the underlyingLifecycleObserverthatMenuHostHelperadds.This has a couple of implications:
removeMenuProvideris called when the Lifecycle is below the givenstate,removeMenuProviderdoesn't remove theMenuProviderand when the Lifecycle reaches the given state, it still gets addedremoveMenuProvideris called when the Lifecycle is above the givenstate,removeMenuProviderdoes remove theMenuProvider, but if the Lifecycle goes down and then back up again, it gets re-added.ActivityResultRegistryhandles these cases (registerwith aLifecycleOwner, then callingunregister) byLifecycleOwner+LifecycleObserverinstancesMenuProvideras the key.