Add convenience methods to WorkQuery [199919736]

Fixed

Bug

Status Update

No update yet.

Description

fo...@google.com

created issue #1

Sep 14, 2021 07:37PM

https://osscs.corp.google.com/androidx/platform/frameworks/support/+/androidx-main:work/work-runtime/src/main/java/androidx/work/WorkQuery.java

Creating a WorkQuery to represent a simple request is quite verbose. Eg, for a single id:

WorkQuery.Builder.fromIds(ImmutableList.of(id)).build())

It would be more convenient if:

There was a method on WorkQuery static WorkQuery fromIds() which returned a fully-built WorkQuery for simple cases.
These methods used varargs fromIds(UUID ids...) to avoid needing to build a List inline.

WorkManager has convenience methods for querying with single-element parameters, but not multiple-elements, and RemoteWorkManager lacks these entirely.

Comments

se...@google.com <se...@google.com> Nov 4, 2021 01:03PM

Assigned to se...@google.com.

ap...@google.com <ap...@google.com> #2Nov 5, 2021 07:10PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

ap...@google.com <ap...@google.com> #3Dec 1, 2021 12:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

se...@google.com <se...@google.com> #4Dec 1, 2021 02:17PM

Marked as fixed.

deleted

fo...@google.com <fo...@google.com> #5Dec 15, 2021 03:25AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

tg...@gmail.com <tg...@gmail.com> #6Feb 3, 2023 02:18PM

This CR should be done since Dec 5, 2021 03:17PM, but the methods are still hidden, because they are listed in restricted_current.txt
Is this an intended behavior?

WorkQuery#Builder has some static from...(List<...> ...) methods taking lists as parameter. Maybe it would be good to move the new convenience methods to WorkQuery#Builder as well - and not forget to remove them from restricted_current.txt this time.

se...@google.com <se...@google.com> #7Feb 3, 2023 02:24PM

Which version of workmanager do you use? They're available since 2.8.0-alpha01

tg...@gmail.com <tg...@gmail.com> #8Feb 3, 2023 02:39PM

I see, its the stable from 2021 (2.7.x)