Unable to read any metrics during benchmark in macrobenchmark version 1.1.0-alpha07 [200302931]

Fixed

Bug

Status Update

No update yet.

Description

de...@tokopedia.com

created issue #1

Sep 18, 2021 07:15AM

I was trying to upgrade my macrobenchmark version from 1.1.0-alpha02 to 1.1.0-alpha07. And now I'm always encountered this error:

There was 1 failure:
1) macroBenchmarkHomeLaunchTime[mode=COLD](com.testapp.macrobenchmark.test.home.HomeStartupBenchmark)
java.lang.IllegalArgumentException: Unable to read any metrics during benchmark (metric list: [androidx.benchmark.macro.StartupTimingMetric@1fce2f9]).
Check that you're performing the operations to be measured. For example, if
using StartupTimingMetric, are you starting an activity for the specified package
in the measure block?
at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmark(Macrobenchmark.kt:198)
at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmarkWithStartupMode(Macrobenchmark.kt:259)
at androidx.benchmark.macro.junit4.MacrobenchmarkRule.measureRepeated(MacrobenchmarkRule.kt:68)
at com.testapp.macrobenchmark.util.MacroTestExtKt.measureStartup(MacroTestExt.kt:19)
at com.testapp.macrobenchmark.test.home.HomeStartupBenchmark.macroBenchmarkHomeLaunchTime(HomeStartupBenchmark.kt:40)
at java.lang.reflect.Method.invoke(Native Method)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at androidx.benchmark.macro.junit4.MacrobenchmarkRule$applyInternal$1.evaluate(MacrobenchmarkRule.kt:93)
at androidx.test.rule.GrantPermissionRule$RequestPermissionStatement.evaluate(GrantPermissionRule.java:134)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:56)
at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:395)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2205)

FAILURES!!!

After some debugging I checked that `android_startup` field is always empty from generated perfetto-trace file, I think this is the root cause of empty traces during test run. Is there any workaround to prevent this error?

Comments

de...@tokopedia.com <de...@tokopedia.com> #2Sep 18, 2021 12:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit fe2df43a90ef07286b48025029d03b4f5a914af5
Author: Clara Fok <clarafok@google.com>
Date: Fri Jun 23 15:00:32 2023

Convert paging-common project to kmp structure

Splitting main into common, jvm, and native and added build targets in gradle.

Common and native directories are currently empty so project build does not contain output for these two targets yet.

Test: ./gradlew paging:paging-common:jvmTest
Bug: 288623117

Change-Id: I1703692eee416e77e7d4f40d1c1f934783166a86

M development/build_log_simplifier/messages.ignore
M paging/paging-common/build.gradle
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/CachedPageEventFlow.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/CachedPagingData.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/CancelableChannelFlow.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/CombinedLoadStates.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/ConflatedEventBus.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/ContiguousPagedList.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/DataSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/ExperimentalPagingApi.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/FlowExt.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/HintHandler.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/HintReceiver.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/InitialDataSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/InitialPagedList.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/InvalidateCallbackTracker.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/InvalidatingPagingSourceFactory.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/ItemKeyedDataSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/ItemSnapshotList.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/LegacyPageFetcher.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/LegacyPagingSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/LoadState.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/LoadStates.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/LoadType.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/Logger.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/MutableCombinedLoadStateCollection.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/MutableLoadStateCollection.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/NullPaddedList.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PageEvent.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PageFetcher.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PageFetcherSnapshot.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PageFetcherSnapshotState.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PageKeyedDataSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagePresenter.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagedList.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagedListConfig.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagedStorage.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/Pager.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagingConfig.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagingData.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagingDataDiffer.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagingDataTransforms.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagingSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagingSourceFactory.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagingState.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PositionalDataSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/RemoteMediator.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/RemoteMediatorAccessor.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/Separators.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/SimpleChannelFlow.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/SingleRunner.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/SnapshotPagedList.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/SuspendingPagingSourceFactory.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/TransformablePage.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/UiReceiver.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/ViewportHint.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/WrapperDataSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/WrapperItemKeyedDataSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/WrapperPageKeyedDataSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/WrapperPositionalDataSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/internal/Constants.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/internal/LogUtil.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/CachedPageEventFlowLeakTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/CachedPageEventFlowTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/CachingTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/ConflatedEventBusTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/ContiguousPagedListTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/DataSourceTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/FailDispatcher.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/FlattenedPageEventStorageTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/FlowExtTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/GarbageCollectionTestHelper.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/HeaderFooterTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/HintHandlerTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/InvalidatingPagingSourceFactoryTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/ItemKeyedDataSourceTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/ItemSnapshotListTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/LegacyPageFetcherTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/LegacyPagingSourceTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PageEventTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PageFetcherSnapshotStateTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PageFetcherTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PageKeyedDataSourceTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PagePresenterTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PagedListConfigBuilderTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PagedListConfigTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PagedListTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PagedStorageTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PagingConfigTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PagingDataDifferTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PagingSourceTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PagingStateTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/PositionalDataSourceTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/ProcessPageEventCallbackCapture.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/RemoteMediatorAccessorTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/SeparatorsTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/SeparatorsWithRemoteMediatorTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/SimpleChannelFlowTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/SimpleTransformLatestTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/SingleRunnerTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/StateChange.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/TestPagingSourceExt.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/TestUtils.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/WrappedItemKeyedDataSourceTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/WrappedPageKeyedDataSourceTest.kt
M paging/paging-common/src/jvmTest/kotlin/androidx/paging/WrappedPositionalDataSourceTest.kt

https://android-review.googlesource.com/2636227

cc...@google.com <cc...@google.com> #3Oct 6, 2021 11:36PM

Project: platform/frameworks/support
Branch: androidx-main

commit 45a39b3d17e70ccc588bb984f73618b1985a3cc0
Author: Clara Fok <clarafok@google.com>
Date: Fri Jun 30 12:21:09 2023

Rename jvmMain files to .jvm.kt

Ensure unique path to prevent duplicated class errors.

PagedList and PagedListConfig are NOT renamed because it breaks compatibility and since it contains public functions, should not be renamed per discussion in thread

https://chat.google.com/room/AAAAkD37w58/LOjte8_d9K8

Test: ./gradlew buildOnServer
Bug: 288623117
Change-Id: Iede0d9715ff4bdd17ca4e2fe94c0899489d9b39a

M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataTransforms.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/ContiguousPagedList.jvm.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/DataSource.jvm.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/InitialDataSource.jvm.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/InitialPagedList.jvm.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/ItemKeyedDataSource.jvm.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/LegacyPageFetcher.jvm.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/LegacyPagingSource.jvm.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PageKeyedDataSource.jvm.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagedStorage.jvm.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PositionalDataSource.jvm.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/SnapshotPagedList.jvm.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/WrapperDataSource.jvm.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/WrapperItemKeyedDataSource.jvm.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/WrapperPageKeyedDataSource.jvm.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/WrapperPositionalDataSource.jvm.kt

https://android-review.googlesource.com/2647603

ap...@google.com <ap...@google.com> #4Oct 13, 2021 12:08AM

Project: platform/frameworks/support
Branch: androidx-main

commit 75107d52be492198ec61504c0b347e85127514d2
Author: Clara Fok <clarafok@google.com>
Date: Fri Jun 30 12:18:52 2023

Move PagingDataTransforms java util methods to jvmMain

Test: ./gradlew paging:paging-common:jvmTest
Bug: 288623117
Change-Id: I01935da0c9160ae3e8b0705d69bd086ab08337ba

M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataTransforms.kt
A paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagingDataTransforms.jvm.kt

https://android-review.googlesource.com/2647602

cc...@google.com <cc...@google.com> #5Oct 13, 2021 12:59AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit a69200acae2cea60ce0b473134445d050be580cb
Author: Clara Fok <clarafok@google.com>
Date: Fri Jun 30 12:04:07 2023

Migrate all Paging3 classes to commonMain

Test: ./gradlew paging:paging-common:jvmTest
Bug: 288623117
Change-Id: I2a37c3c7c9002d0a43b9f9c254f8584e3cc27dba

M paging/paging-common/src/commonMain/kotlin/androidx/paging/CachedPageEventFlow.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/CachedPagingData.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/ExperimentalPagingApi.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/FlowExt.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/HintHandler.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/HintReceiver.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/InvalidateCallbackTracker.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/InvalidatingPagingSourceFactory.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/Logger.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/MutableCombinedLoadStateCollection.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageEvent.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageFetcher.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageFetcherSnapshot.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageFetcherSnapshotState.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagePresenter.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/Pager.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingConfig.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingData.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataDiffer.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataTransforms.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingSource.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingSourceFactory.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingState.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/RemoteMediator.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/RemoteMediatorAccessor.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/Separators.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/SingleRunner.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/SuspendingPagingSourceFactory.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/TransformablePage.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/ViewportHint.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/CachedPageEventFlowLeakTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/CachedPageEventFlowTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/CachingTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/FailDispatcher.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/FlattenedPageEventStorageTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/FlowExtTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/GarbageCollectionTestHelper.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/HeaderFooterTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/HintHandlerTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/InvalidatingPagingSourceFactoryTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageEventTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherSnapshotStateTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagePresenterTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingConfigTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingDataDifferTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingSourceTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingStateTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/ProcessPageEventCallbackCapture.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/RemoteMediatorAccessorTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SeparatorsTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SeparatorsWithRemoteMediatorTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SimpleChannelFlowTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SimpleTransformLatestTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/SingleRunnerTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/StateChange.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/TestPagingSourceExt.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/TestUtils.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagedList.kt

https://android-review.googlesource.com/2647601

c....@gmail.com <c....@gmail.com> #6Jun 3, 2022 06:33AM

Project: platform/frameworks/support
Branch: androidx-main

commit b536469eba96d3045cf26ee40bf87a4b1d579dbe
Author: Clara Fok <clarafok@google.com>
Date: Fri Jun 30 11:57:20 2023

Remove @JvmDefaultWithCompatibility from Logger.kt

Annotation was added in

b/251463569

to maintain binary compatibility.

But Logger is only used internally and we want to move this file to commonMain hence removing it.

Test: ./gradlew buildOnServer
Bug: 288623117
Relnote: "Remove @JvmDefaultWithCompatibility annotation"
Change-Id: I9b67c2e081a15e18797b68f5ce2224858e358a1d

M paging/paging-common/api/current.txt
M paging/paging-common/api/restricted_current.txt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/Logger.kt

https://android-review.googlesource.com/2647600

ni...@gmail.com <ni...@gmail.com> #7Jun 7, 2022 11:04AM

Project: platform/frameworks/support
Branch: androidx-main

commit 19c9fbd2252535dcb858faf39c1629a9771f9675
Author: Clara Fok <clarafok@google.com>
Date: Fri Jun 30 10:59:11 2023

Add CompatLegacyPagingSource in commonMain

LegacyPagingSource relies on PageFetcher to set the pageSize on new instance creation because LegacyPagingSource does not have access to PagingConfig. By adding CompatLegacyPagingSource interface, PageFetcher in commonMain can reference LegacyPagingSource in jvmMain.

Test: ./gradlew paging:paging-common:jvmTest
Bug: 288623117
Change-Id: I0ef1e7f0426b237d47beffbb4f1197d1e8d21ee5

A paging/paging-common/src/commonMain/kotlin/androidx/paging/CompatLegacyPagingSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/LegacyPagingSource.kt
M paging/paging-common/src/jvmMain/kotlin/androidx/paging/PageFetcher.kt

https://android-review.googlesource.com/2647599

Message last modified on Jun 7, 2022 11:05AM

ni...@gmail.com <ni...@gmail.com> #8Jun 8, 2022 08:01AM

Project: platform/frameworks/support
Branch: androidx-main

commit 6b5c1832b782dc20efb9e7bf90d89809efed491a
Author: Clara Fok <clarafok@google.com>
Date: Wed Jul 05 12:50:54 2023

Fix partial native build errors

Test: ./gradlew paging:paging-common:allTests
Bug: 288623117
Change-Id: Iad3a9bf06bbec2e9ab20328961effd1dd5e1b5b8

M paging/paging-common/src/commonTest/kotlin/androidx/paging/CachedPageEventFlowLeakTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherSnapshotTest.kt

https://android-review.googlesource.com/2647529

va...@gmail.com <va...@gmail.com> #9Oct 13, 2022 06:06PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8448061e4d0ec86ed6431908dc93e5689d632c31
Author: Clara Fok <clarafok@google.com>
Date: Fri Jul 07 19:13:03 2023

Refactor Logger to PagingLogger

PagingLogger is now an expect object to be implemented by platforms.

Logger interface has been deprecated.

Test: ./gradlew paging:paging-common:allTests
Bug: 288623117
Relnote: "Logger interface has been deprecated"

Change-Id: I16e9505d60bbe864528e0be2266668c6140bcc24

M paging/paging-common/api/current.txt
M paging/paging-common/api/restricted_current.txt
A paging/paging-common/src/androidMain/kotlin/androidx/paging/PagingLogger.android.kt
A paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/Logger.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingLogger.kt
A paging/paging-common/src/jvmMain/kotlin/androidx/paging/PagingLogger.jvm.kt
A paging/paging-common/src/nativeMain/kotlin/androidx/paging/PagingLogger.native.kt
M paging/paging-compose/src/main/java/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-runtime/src/main/java/androidx/paging/AsyncPagingDataDiffer.kt

https://android-review.googlesource.com/2651250

ma...@gmail.com <ma...@gmail.com> #10Mar 1, 2023 07:36AM

Project: platform/frameworks/support
Branch: androidx-main

commit 5f18ef3219b7e3c11928df68cd144f3ae27a35c9
Author: Clara Fok <clarafok@google.com>
Date: Fri Jul 07 19:10:23 2023

Add commonJvmAndroidMain source set

Shared source set between android and jvm

Test: ./gradlew paging:paging-common:allTests
Bug: 288623117
Change-Id: I1a3cb7ab78dcf9e9856e1d83598cfc5697165e41

M paging/paging-common/build.gradle
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/ContiguousPagedList.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/DataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/InitialDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/InitialPagedList.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/ItemKeyedDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/LegacyPageFetcher.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/LegacyPagingSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/MainThread.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PageKeyedDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagedList.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagedListConfig.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagedStorage.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagingDataTransforms.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PositionalDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/SnapshotPagedList.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/WrapperDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/WrapperItemKeyedDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/WrapperPageKeyedDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/WrapperPositionalDataSource.jvm.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/CachedPageEventFlowLeakTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/ContiguousPagedListTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/DataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/GarbageCollectionTestHelper.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/ItemKeyedDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/LegacyPageFetcherTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/LegacyPagingSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PageFetcherTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PageKeyedDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PagedListConfigBuilderTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PagedListConfigTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PagedListTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PagedStorageTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PositionalDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/SingleRunnerTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/WrappedItemKeyedDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/WrappedPageKeyedDataSourceTest.kt
M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/WrappedPositionalDataSourceTest.kt

https://android-review.googlesource.com/2651249

ma...@propertyfinder.ae <ma...@propertyfinder.ae> #11Mar 3, 2023 05:41AM

Project: platform/frameworks/support
Branch: androidx-main

commit 8ca12ffa12870c18855d58b559722ee016fc5273
Author: Clara Fok <clarafok@google.com>
Date: Wed Jul 05 17:24:35 2023

Make paging-common an android library

This allows paging-common to support android-specific implementations such as android logging.

Test: ./gradlew paging:paging-common:allTests
Bug: 288623117
Change-Id: Ia8804f1fb09ce1bb4270315358d8e77bf56a556b

A paging/paging-common/api/res-3.2.0-beta01.txt
A paging/paging-common/api/res-current.txt
M paging/paging-common/build.gradle

https://android-review.googlesource.com/2651248

ro...@gmail.com <ro...@gmail.com> #12Jan 31, 2024 07:25PM

Comment has been deleted.

Message last modified on Jan 31, 2024 07:25PM