In Progress
Status Update
Comments
yb...@google.com <yb...@google.com> #2
This would mean adding API 35 screenshot tests, then turning down API 33 screenshot tests.
zh...@google.com <zh...@google.com>
pa...@gmail.com <pa...@gmail.com> #3
Have the same issue. Any solutions for this?
zh...@google.com <zh...@google.com> #4
Following up on
yb...@google.com <yb...@google.com> #5
Based on API council feedback, set(null)
is not a desired API, as it conflicts with how other collections work.
e.g. if you have Map<Int, String>
, you cannot call myMap[3] = null
and expect it to mean clear it
.
We might either open up the Key constructor or create nullable variants to allow this but either of those will require an API change that we cannot do in 1.1
zh...@google.com <zh...@google.com> #6
Thanks for the inputs - I've updated the hotlist to be datastore-1.2
Description
I'm using datastore preferences but I'm currently unable to set a null/nullable value (see TestRepository from the attached sample project).
From a first look at the code I believe the value parameter type of the set operator of MutablePreference should be nullable since the null value is actually handled inside the setUnchecked function.
I have noticed this parameter is already reported as nullable in the generated metadata API but that does not reflect the current code.
Also the documentation for the set operator is wrong: in the parameters table the second parameter should be value instead of key.
DataStore Component used: datastore-preferences
DataStore Version used: 1.0.0
Devices/Android versions reproduced on: Android 12 Beta 5