NewApi lint check doesn't honor Robolectric SDK configurations [200599470]

Fixed

Bug

Status Update

No update yet.

Description

tr...@google.com

created issue #1

Sep 20, 2021 08:59PM

After enabling lint on test sources, the NewApi lint check will be triggered in robolectric tests even if the test is configured with a minSdk lower than the API being used. To work around this issues, users are required to add a redundant @RequiresApi() or @TargetApi() annotation to their test method or test class.

STEPS TO REPRODUCE:

Enable lint in test sources inside build.gradle:

android {
    lintOptions.checkTestSources = true
}

Create a robolectric test inside src/test/...
Annotate the robolectric test with @Config(minSdk = <minsdk>) (or configure the SDK with robolectric.properties). Also ensure android.defaultConfig.minSdkVersion is lower than minsdk so it doesn't get suppressed that way.
Use an android class that was added in sdk <= minsdk (I used android.util.Size which was added in API 21 and set minsdk to 23, for example). Alternatively, annotate a method or class with @RequiresApi(<sdk>) and use it in a test.
Run ./gradlew app:lint and see NewApi failures.

Example:

@RunWith(RobolectricTestRunner.class)
@Config(minSdk = 23)
public class ExampleRobolectricTest {
    @Test
    public void createSize() {
        new Size(0, 0);
    }
}

Studio Build:

Android Studio Arctic Fox | 2020.3.1 Patch 2
Build #AI-203.7717.56.2031.7678000, built on August 26, 2021
Runtime version: 11.0.10+0-b96-7281165 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 11.6
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 8
Registry: external.system.auto.import.disabled=true

Version of Gradle Plugin: 7.1.0-alpha03

Comments

ja...@google.com <ja...@google.com> Sep 22, 2021 06:53PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> Sep 27, 2021 11:47PM

Reassigned to sp...@google.com.

sp...@google.com <sp...@google.com> #2Sep 29, 2021 06:07PM

Reassigned to tn...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3151736

tn...@google.com <tn...@google.com> #3Sep 29, 2021 11:18PM

Project: platform/frameworks/support
Branch: androidx-main

commit 39cd1e9f7579513bde139c17f9c51f9012d56152
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

Reland

r.android.com/3151736 now with workaround for

https://youtrack.jetbrains.com/issue/KT-62653

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Ic795af8486db48b31633799e06665717d08398db

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3156121

tn...@google.com <tn...@google.com> Sep 30, 2021 12:41AM

Marked as fixed.

sa...@google.com <sa...@google.com> #4Oct 16, 2021 12:08AM

Project: platform/frameworks/support
Branch: androidx-main

commit c3a06e79cf427aef1cf0ede1bacb463eb89472be
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

Reland

r.android.com/3151736 /

r.android.com/3156121 but now with
moving to project(":annotation:annotation") in commonMain as due to

https://youtrack.jetbrains.com/issue/KT-62653 we cannot depend on
project in one source set and prebuilt in the other.

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: I7f2a1bddbe79ab5e920cdb01ca6a428950a8c2c3

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M busytown/androidx_multiplatform_mac_host_tests_arm64.sh
M camera/integration-tests/avsynctestapp/build.gradle
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt
M test/uiautomator/integration-tests/testapp/build.gradle
M wear/compose/integration-tests/navigation/build.gradle

https://android-review.googlesource.com/3156423

Issue 200599470