Fixed
Status Update
No update yet.
Comments
ni...@google.com
il...@google.com
ap...@google.com
Hi. Thanks for reporting this. Fixed in alpha-04
il...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
Description
Android Studio Build: 2020.3.1 Patch 2
Kotlin version: 1.5.21
Issue:
Expected behaviour would be that each ViewModel instance should stay the same when selecting the bottomBar tabs.
In practice - the ViewModel instances change, if switching is happening very fast.
I'm not totally sure whether this is compose issue, compose-navigation issue, or Dagger Hilt issue since they all are related here.
An important note - setup in the reproducible sample is supporting multiple back stacks.
Steps to Reproduce:
1. start the project where the issue can be reproduced
2. it contains a function imitateFastNavigation(), which will simulate fast switching bottomBar destinations. Same can be done by commenting it out and fast tapping manually.
3. Open the logcat, and ensure that the viewModels are actually changing, instead of being the same.